-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy images with exact version (not only latest/build number) #75
Changes from 1 commit
f3420ff
a4f289c
5f09de0
d186fda
c0e6afb
cdd56e8
3504ce4
60cec97
902925d
4c9d27d
50286e5
9ecc6da
940be38
0b18b7e
0c4a609
9ca763c
2252fd2
4066c82
ee0850d
219e2ba
28fb575
1922e4c
aff3786
d172f44
4572bee
6a926f3
2b569c7
69ef420
141bd3f
d8ea955
ffbcdae
8890e26
228360e
0bd7747
0e14dc6
1d24148
f59f853
f7fe9e8
f67f05d
d19f4ad
ddb369c
4b37eb9
ae808a5
630d56b
db880c8
8a4c00b
e42d9ff
5e99b4e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -80,6 +80,7 @@ public void ConfigureServices (IServiceCollection services) { | |||
Configuration.GetValue<int>("KeyManagement:KeyVault:MaximumDataLength")); | ||||
case "AESKey": | ||||
var key = Configuration.GetValue<string>("KeyManagement:AES:Key"); | ||||
Console.WriteLine($"AES key used: {key}"); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
if (string.IsNullOrEmpty(key)) | ||||
{ | ||||
Log.ForContext<Startup>().Warning("Random key was created for SymmetricKeyManagement, it might break distributed deployments"); | ||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
using System; | ||
using System.IO; | ||
using System.Reflection; | ||
using System.Threading.Tasks; | ||
using Google.Apis.Auth.OAuth2; | ||
using Google.Apis.CloudKMS.v1; | ||
|
@@ -28,15 +29,16 @@ public Startup(IHostingEnvironment env) | |
appsettingsPath = "appsettings.Development.json"; | ||
} | ||
|
||
Console.WriteLine($"Root: {env.ContentRootPath}"); | ||
|
||
var builder = new ConfigurationBuilder() | ||
.SetBasePath(env.ContentRootPath) | ||
.AddJsonFile(appsettingsPath, optional: true, reloadOnChange: true) | ||
.AddJsonFile("secrets/appsettings.secrets.json", optional: true) | ||
.AddEnvironmentVariables(); | ||
|
||
Configuration = builder.Build(); | ||
Configuration = builder.Build(); | ||
|
||
var version = Assembly.GetExecutingAssembly().GetName().Version.ToString(); | ||
Console.WriteLine($"Kamus Encryptor API {version} starting"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why you don't use the logger? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above... |
||
} | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you don't use the logger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is called before the logger is initialized