Deploy images with exact version (not only latest/build number) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaikatz
reviewed
Jan 15, 2019
src/decrypt-api/Startup.cs
Outdated
| @@ -80,6 +80,7 @@ public Startup(IHostingEnvironment env) | |||
| Configuration.GetValue<int>("KeyManagement:KeyVault:MaximumDataLength")); | |||
| case "AESKey": | |||
| var key = Configuration.GetValue<string>("KeyManagement:AES:Key"); | |||
| Console.WriteLine($"AES key used: {key}"); | |||
There was a problem hiding this comment.
Why you don't use the logger?
There was a problem hiding this comment.
I think this is called before the logger is initialized
shaikatz
reviewed
Jan 15, 2019
| Configuration = builder.Build(); | ||
|
|
||
| var version = Assembly.GetExecutingAssembly().GetName().Version.ToString(); | ||
| Console.WriteLine($"Kamus Encryptor API {version} starting"); |
There was a problem hiding this comment.
Why you don't use the logger?
added 26 commits
January 15, 2019 11:45
added 19 commits
January 16, 2019 21:14
shaikatz
reviewed
Jan 17, 2019
src/decrypt-api/Startup.cs
Outdated
| @@ -80,6 +80,7 @@ public Startup(IHostingEnvironment env) | |||
| Configuration.GetValue<int>("KeyManagement:KeyVault:MaximumDataLength")); | |||
| case "AESKey": | |||
| var key = Configuration.GetValue<string>("KeyManagement:AES:Key"); | |||
| Console.WriteLine($"AES key used: {key}"); | |||
There was a problem hiding this comment.
Suggested change
| Console.WriteLine($"AES key used: {key}"); |
shaikatz
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #74