New APIs for Update workflow #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding definitions for SOP Update Check/Download actions.
3 tasks
elliot-huffman
requested changes
Nov 9, 2024
Contributor
elliot-huffman
left a comment
elliot-huffman
left a comment
There was a problem hiding this comment.
Additionally, I don't see a tag object that corresponds to the new SOP update/update tag. Pretty close. I like the API design in general! Just some tweaks and it will be approved.
Using correct name to reference application as Shield
Ensure all endpoints are properly described. Adding missing properties to present user-friendly output
pasha-zayko
changed the title
Update wording to indicate which tenant and permissions are required for update service configurations. Update the tags to be more descriptive. Formatting.
elliot-huffman
approved these changes
Jan 15, 2025
Contributor
elliot-huffman
left a comment
elliot-huffman
left a comment
There was a problem hiding this comment.
After polish, fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding definitions for SHIELD Update Check/Download actions.