-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved stealth in stealth mode #6110
Open
pimlie
wants to merge
9
commits into
SoftFever:main
Choose a base branch
from
pimlie:fix-stealth-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+175
−13
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1869609
feat: add stealth mode select to setup wizard
pimlie 1d41aa8
fix: never call BBL api when stealth mode is enabled
pimlie 9fa0fd8
Merge branch 'main' into fix-stealth-mode
pimlie 2498f33
fix: improve text & fit dialog window to size
pimlie c6c04ef
Merge branch 'main' into fix-stealth-mode
pimlie f04d41b
feat: add sync_on_start config option
pimlie 40d4095
chore: revert changes to download progress dialog
pimlie e2af9f7
Merge branch 'main' into fix-stealth-mode
pimlie 669e67b
Merge branch 'main' into fix-stealth-mode
pimlie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
line-height: 30px; | ||
} | ||
|
||
#InstallCheck | ||
#InstallCheck, #SyncCheck | ||
{ | ||
width: 30px; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
|
||
#Content | ||
{ | ||
padding:0% 15%; | ||
} | ||
|
||
#FeatureText | ||
{ | ||
line-height: 30px; | ||
margin-top: 10mm; | ||
} | ||
|
||
|
||
#CheckArea | ||
{ | ||
margin-top:10mm; | ||
line-height: 30px; | ||
} | ||
|
||
#SyncCheck | ||
{ | ||
width: 30px; | ||
} | ||
|
||
#RestartText | ||
{ | ||
padding-left:30px; | ||
} | ||
|
||
.TextPoint | ||
{ | ||
font-size:14px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
|
||
function OnInit() | ||
{ | ||
TranslatePage(); | ||
|
||
SendStealthModeCheck(); | ||
} | ||
|
||
|
||
|
||
function SendSyncOnStartCheck() | ||
{ | ||
let nVal="no"; | ||
if( $('#SyncCheck').is(':checked') ) | ||
nVal="yes"; | ||
|
||
var tSend={}; | ||
tSend['sequence_id']=Math.round(new Date() / 1000); | ||
tSend['command']="save_sync_on_start"; | ||
tSend['data']={}; | ||
tSend['data']['action']=nVal; | ||
|
||
SendWXMessage( JSON.stringify(tSend) ); | ||
|
||
return true; | ||
} | ||
|
||
function GotoNetPluginPage() | ||
{ | ||
let bRet=SendStealthModeCheck(); | ||
|
||
if(bRet) | ||
window.location.href="../5/index.html"; | ||
} | ||
|
||
function FinishGuide() | ||
{ | ||
var tSend={}; | ||
tSend['sequence_id']=Math.round(new Date() / 1000); | ||
tSend['command']="user_guide_finish"; | ||
tSend['data']={}; | ||
tSend['data']['action']="finish"; | ||
|
||
SendWXMessage( JSON.stringify(tSend) ); | ||
|
||
//window.location.href="../6/index.html"; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<!doctype html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta http-equiv="Cache-Control" content="max-age=7200" /> | ||
<title>引导_P1</title> | ||
<link rel="stylesheet" type="text/css" href="../css/common.css" /> | ||
<link rel="stylesheet" type="text/css" href="../css/dark.css" /> | ||
<link rel="stylesheet" type="text/css" href="7orca.css" /> | ||
<script type="text/javascript" src="../js/jquery-2.1.1.min.js"></script> | ||
<script type="text/javascript" src="../js/json2.js"></script> | ||
<script type="text/javascript" src="../../data/text.js"></script> | ||
<script type="text/javascript" src="../js/globalapi.js"></script> | ||
<script type="text/javascript" src="../js/common.js"></script> | ||
<script type="text/javascript" src="7orca.js"></script> | ||
</head> | ||
<body onLoad="OnInit()"> | ||
<div id="Title"> | ||
<div class="trans" tid="orca6">Sync on start</div> | ||
</div> | ||
<div id="Content"> | ||
|
||
<div id="FeatureText"> | ||
<div tid="orca7" class="trans">OrcaSlicer will check for the latest Bambu Network plug-in version and latest Bambu printer configuration on application start. Uncheck the following option if you do not want this. Users who don't use BBL machines can safely turn this off</div> | ||
</div> | ||
|
||
<label id="CheckArea"><input id="SyncCheck" onClick="SendSyncOnStartCheck()" type="checkbox" checked><a tid="orca8" class="trans TextS1">Sync latest Bambu Network plug-in and printer configuration on application start</a></label> | ||
<div id="RestartText" tid="t70" class="trans" ></div> | ||
|
||
</div> | ||
<div id="AcceptArea"> | ||
<div class="GrayBtn trans" tid="t8" id="PreBtn" onclick="window.history.back()">Back</div> | ||
<div class="NormalBtn trans" tid="t25" id="AcceptBtn" onclick="FinishGuide()">Finish</div> | ||
</div> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently plugin is no controlled by stealth flag, it's enabled networking option that controls it.
I'm afraid disabling plugin downloading will confuse user.
Better don't do it.
Stealth flag mainly disable HMS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok.
Wdyt about renaming stealth mode to something clearer then? Maybe:
renamenot implementedstealth_mode
toenable_bambulab_hms
sync_on_start
flag so users can toggle whether sync_plugins & sync_printer_config should be called on application startSee screenshots in OP for added checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, the
Sync on start
wizard option comes after the Propietary Plugins step and is now the last wizard step