fix: improved stealth in stealth mode #6110
Open
+175
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: enable stealth mode until user finishes setup wizard
SoftFever
reviewed
Aug 1, 2024
|
|
||
| // orca: http_url is empty string in stealth_mode | ||
| if (http_url.size() > 0) { | ||
| this->p->sync_plugins(http_url, plugin_version); |
There was a problem hiding this comment.
Currently plugin is no controlled by stealth flag, it's enabled networking option that controls it.
I'm afraid disabling plugin downloading will confuse user.
Better don't do it.
Stealth flag mainly disable HMS
There was a problem hiding this comment.
Ah ok.
Wdyt about renaming stealth mode to something clearer then? Maybe:
renamenot implementedstealth_modetoenable_bambulab_hms- add
sync_on_startflag so users can toggle whether sync_plugins & sync_printer_config should be called on application start
See screenshots in OP for added checks
There was a problem hiding this comment.
To clarify, the Sync on start wizard option comes after the Propietary Plugins step and is now the last wizard step
add support for users to disable syncing bbl network plugin and printer configuration on app start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6102
ℹ️ This is a draft as it's based on pr #6104, once 6104 is merged then this can be mergedDescription
Screenshots/Recordings/Graphs
Tests
na