-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved stealth in stealth mode #6110
base: main
Are you sure you want to change the base?
Conversation
feat: enable stealth mode until user finishes setup wizard
|
||
// orca: http_url is empty string in stealth_mode | ||
if (http_url.size() > 0) { | ||
this->p->sync_plugins(http_url, plugin_version); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently plugin is no controlled by stealth flag, it's enabled networking option that controls it.
I'm afraid disabling plugin downloading will confuse user.
Better don't do it.
Stealth flag mainly disable HMS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok.
Wdyt about renaming stealth mode to something clearer then? Maybe:
renamenot implementedstealth_mode
toenable_bambulab_hms
- add
sync_on_start
flag so users can toggle whether sync_plugins & sync_printer_config should be called on application start
See screenshots in OP for added checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, the Sync on start
wizard option comes after the Propietary Plugins step and is now the last wizard step
add support for users to disable syncing bbl network plugin and printer configuration on app start
Fix #6102
ℹ️ This is a draft as it's based on pr #6104, once 6104 is merged then this can be mergedDescription
Screenshots/Recordings/Graphs
Tests
na