Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Overhang Printable #1615

Merged
merged 16 commits into from
Jul 30, 2023
Merged

Make Overhang Printable #1615

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9c50c23
First working conical overhang impl
Noisyfox Jul 17, 2023
6b7fae2
Add settings for Make overhang printable
odie5533 Jul 4, 2023
4c1700e
Merge branch 'main' into overhang-settings
SoftFever Jul 18, 2023
1ffcd09
Retain recesses in the bottom of the model when "Make Overhangs Print…
Noisyfox Jul 19, 2023
46e1b32
Add settings for Make overhang printable hole size
Noisyfox Jul 19, 2023
8f828d1
Merge branch 'main' into overhang-settings
odie5533 Jul 19, 2023
9088739
Allow disabling conical overhang per modifier
Noisyfox Jul 22, 2023
fe6b05c
Should check upper layer instead
Noisyfox Jul 22, 2023
a54e85f
Skip unnecessary layers
Noisyfox Jul 22, 2023
8f97716
Merge remote-tracking branch 'remote/main' into dev/overhang
Noisyfox Jul 28, 2023
ad4dc40
Apply conical overhang before any size compensation
Noisyfox Jul 28, 2023
60ff70d
Merge branch 'main' into dev/overhang
Noisyfox Jul 28, 2023
a9838ff
1. Fix an issue that changing make_overhang_printable related paramet…
SoftFever Jul 29, 2023
7cfcbb2
Change default make_overhang_printable_angle to 55
SoftFever Jul 29, 2023
ab39a21
One more missing commit
SoftFever Jul 29, 2023
1f24c8f
1. Skip checking default_region_config()->make_overhang_printable
SoftFever Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Should check upper layer instead
  • Loading branch information
@Noisyfox
Noisyfox committed Jul 22, 2023
commit fe6b05c79738f72d5f1f0b1fc71f5ff3dbc7dfb8
2 changes: 1 addition & 1 deletion src/libslic3r/PrintObjectSlice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,7 @@ void PrintObject::apply_conical_overhang() {
// layer->m_regions[region_id]->slices.surfaces);

// Disable on given region
if (layer->m_regions[region_id]->region().config().make_overhang_printable_disable) {
if (upper_layer->m_regions[region_id]->region().config().make_overhang_printable_disable) {
continue;
}

Expand Down