Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Overhang Printable #1615

Merged
merged 16 commits into from
Jul 30, 2023
Merged

Make Overhang Printable #1615

merged 16 commits into from
Jul 30, 2023

Conversation

Noisyfox
Copy link
Collaborator

This replaces PR #1556

@SoftFever
Copy link
Owner

Hey @Noisyfox @odie5533 ,

The PR looks to be in good shape.
I made some fixes/changes below:

  1. Fixed an issue where changing 'make_overhang_printable' related parameters wouldn't clear caches properly.
  2. Tweaked the logic of the 'make_overhang_printable' parameter to work for per region/object/print level, and removed the 'make_overhang_printable_disable' parameter.
  3. Set the default 'make_overhang_printable_angle' to 55 degrees.

Please review and test these changes. If everything looks good, we're good to merge it. 👍

@Noisyfox
Copy link
Collaborator Author

With the change of the settings logic, now you can enable this setting on a single object without enabling the global one, however it won't be affective because of https://github.com/SoftFever/OrcaSlicer/pull/1615/files#diff-ae94698c496da8738c4a6413f08caa1e42aa965ba9de3960207d41943816df9fR1179-R1181

which makes this a bit confusing:

image
image

2. Handle make_overhang_printable_angle and make_overhang_printable_hole_size value change
@SoftFever
Copy link
Owner

With the change of the settings logic, now you can enable this setting on a single object without enabling the global one, however it won't be affective because of https://github.com/SoftFever/OrcaSlicer/pull/1615/files#diff-ae94698c496da8738c4a6413f08caa1e42aa965ba9de3960207d41943816df9fR1179-R1181

which makes this a bit confusing:

image image

Agreed.
I have reverted that change.

@Noisyfox
Copy link
Collaborator Author

LGTM

@odie5533
Copy link

I have not tested a later build, but my brother had mentioned the early ones seemed to mark the interior as 'bridging' and so prints would take a lot longer, in some cases twice as long. Was this fixed or changed with some of the logic changes? Otherwise I can try testing it again to narrow down the issue.

@SoftFever
Copy link
Owner

@odie5533
I'm not aware of the issue you mentioned.
Not sure if @Noisyfox know about this.

It would be great if you can test with the latest build.

@Noisyfox
Copy link
Collaborator Author

I have not tested a later build, but my brother had mentioned the early ones seemed to mark the interior as 'bridging' and so prints would take a lot longer, in some cases twice as long. Was this fixed or changed with some of the logic changes? Otherwise I can try testing it again to narrow down the issue.

I think that's the same issue as #1556 (comment) which should have been fixed.

@SoftFever
Copy link
Owner

I have not tested a later build, but my brother had mentioned the early ones seemed to mark the interior as 'bridging' and so prints would take a lot longer, in some cases twice as long. Was this fixed or changed with some of the logic changes? Otherwise I can try testing it again to narrow down the issue.

I think that's the same issue as #1556 (comment) which should have been fixed.

Great! I'm going to merge this PR.
If there are any issues, feel free to raise an ticket. @odie5533

@SoftFever SoftFever merged commit b571318 into SoftFever:main Jul 30, 2023
4 checks passed
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Dec 23, 2023
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Dec 23, 2023
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Feb 26, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Feb 27, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 8, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 24, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 26, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Mar 29, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Apr 18, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Apr 23, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request May 7, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request May 7, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request May 7, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 1, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 8, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 13, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 14, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 16, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 21, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 23, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Jun 27, 2024
vovodroid added a commit to vovodroid/PrusaSlicer that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants