Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate extrusion width %s as a function of nozzle width, not layer height #1578

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Calculate extrusion width %s as a function of nozzle width, not layer height #1578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
509db89
Calculate extrusion width %s as a function of nozzle width, not layer…
iFallUpHill Jul 22, 2023
548a70e
handled more width conversions
iFallUpHill Jul 23, 2023
18cb687
more missing percent handling
iFallUpHill Jul 23, 2023
daf2069
even more missed percent handling
iFallUpHill Jul 23, 2023
e9b2d98
even more more extrusion % handling
iFallUpHill Jul 23, 2023
6fb9b92
Merge branch 'main' into extrusion_width_nozzle_percent
SoftFever Jul 25, 2023
1c9f1ff
Merge branch 'main' into extrusion_width_nozzle_percent
SoftFever Jul 25, 2023
1e9a4e9
some fixes
SoftFever Jul 25, 2023
aaaf9ab
Merge branch 'main' into extrusion_width_nozzle_percent
SoftFever Jul 25, 2023
95bb893
Merge branch 'main' into extrusion_width_nozzle_percent
SoftFever Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more missing percent handling
  • Loading branch information
@iFallUpHill
iFallUpHill committed Jul 23, 2023
commit 18cb687962ec9d5baa90548799897b96f0181972
2 changes: 1 addition & 1 deletion src/libslic3r/SupportMaterial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,7 +2252,7 @@ PrintObjectSupportMaterial::MyLayersPtr PrintObjectSupportMaterial::top_contact_

// check if the sharp tails should be extended higher
bool detect_first_sharp_tail_only = false;
const coordf_t extrusion_width = m_object_config->get_abs_value("line_width");
const coordf_t extrusion_width = m_object_config->line_width.get_abs_value(object.print()->config().nozzle_diameter.get_at(object.config().support_interface_filament-1));
const coordf_t extrusion_width_scaled = scale_(extrusion_width);
if (is_auto(m_object_config->support_type.value) && g_config_support_sharp_tails && !detect_first_sharp_tail_only) {
for (size_t layer_nr = 0; layer_nr < object.layer_count(); layer_nr++) {
Expand Down
6 changes: 5 additions & 1 deletion src/libslic3r/TreeSupport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,11 @@ TreeSupport::TreeSupport(PrintObject& object, const SlicingParameters &slicing_p
m_object_config->support_interface_pattern == smipConcentric ?
ipConcentric :
(m_support_params.interface_density > 0.95 ? ipRectilinear : ipSupportBase);
m_support_params.support_extrusion_width = m_object_config->get_abs_value("support_line_width") > 0 ? m_object_config->get_abs_value("support_line_width") : m_object_config->get_abs_value("line_width");

const coordf_t extrusion_width = m_object_config->line_width.get_abs_value(object.print()->config().nozzle_diameter.get_at(object.config().support_interface_filament-1));
const coordf_t support_extrusion_width = m_object_config->support_line_width.get_abs_value(object.print()->config().nozzle_diameter.get_at(object.config().support_interface_filament-1));

m_support_params.support_extrusion_width = support_extrusion_width > 0 ? support_extrusion_width : extrusion_width;
is_slim = is_tree_slim(support_type, support_style);
is_strong = is_tree(support_type) && support_style == smsTreeStrong;
MAX_BRANCH_RADIUS = 10.0;
Expand Down