-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate extrusion width %s as a function of nozzle width, not layer height #1578
Calculate extrusion width %s as a function of nozzle width, not layer height #1578
Conversation
Yes yes yes. This is a huge one. I believe that this single feature will get quite a few people still using SuperSlicer to switch to Orca. Thanks for working on this! I'm very excited that this may be close to release. |
@iFallUpHill
and in src\libslic3r\MultiMaterialSegmentation.cpp:1548
There should be more places to handle percents, you can search for the exact name of all these changed parameters through the whole code base to find them. |
@SoftFever Does this block actually do anything? I couldn't find Gcode.cpp
Edit: Also pretty sure the supports don't calculate correctly anymore :'( |
7347e72
to
18cb687
Compare
@SoftFever Got supports working again, there are a couple of extrusion widths that I think I need to handle still (marked with |
Sure thing. |
I was previously worried about multi-extruder scenarios, but since Orca doesn't support multi-extruder yet, I think we can worry about that later. |
src/libslic3r/PrintConfig.cpp
Outdated
def->mode = comAdvanced; | ||
def->set_default_value(new ConfigOptionFloat(0)); | ||
def->set_default_value(new ConfigOptionFloatOrPercent(0.4, false)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to set default to ConfigOptionFloatOrPercent(0, false)
.
Same for other parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed all except for line_width
It's a placeholder. User can access this variable in their custom g-codes
|
Great feature! Thanks! |
@iFallUpHill |
Thanks for the cleanup, definitely looks a lot cleaner now -- only comment left is the one you mentioned about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged. |
1. Previously if there are multiple sharp tails in a layer, some will be missed. To fix this, we should not skip if the current layer is already detected as sharp tails. 2. Do not mistakenly detect sharp horns as sharp tails by only detecting the overhang areas larger than half of the extrusion line width. Github: #1578 Jira: STUDIO-2659 Change-Id: If7ba5c9ae547d3051551aa6fa34eb6214d01a46d
Reviewable!