Calculate extrusion width %s as a function of nozzle width, not layer height #1578

iFallUpHill · 2023-07-22T23:34:13Z

Reviewable!

… height

jeremytodd1 · 2023-07-23T01:32:38Z

Yes yes yes. This is a huge one.

I believe that this single feature will get quite a few people still using SuperSlicer to switch to Orca.

Thanks for working on this! I'm very excited that this may be close to release.

SoftFever · 2023-07-23T03:58:48Z

@iFallUpHill
Cheers, thanks for taking on this task :)
I found a few places seems not handled properly yet in my initial review.
e.g. in gcode.cpp:1788

           float outer_wall_line_width = print.default_region_config().outer_wall_line_width.value;
            if (outer_wall_line_width == 0.0) {
                float default_line_width = print.default_object_config().line_width.value;
                outer_wall_line_width = default_line_width == 0.0 ? m_config.nozzle_diameter.get_at(initial_non_support_extruder_id) : default_line_width;
            }
            Flow outer_wall_flow = Flow(outer_wall_line_width, m_config.layer_height, m_config.nozzle_diameter.get_at(initial_non_support_extruder_id));
            float outer_wall_speed = print.default_region_config().outer_wall_speed.value;

and in src\libslic3r\MultiMaterialSegmentation.cpp:1548

    auto layer_color_stat = [&layers = std::as_const(layers)](const size_t layer_idx, const size_t color_idx) -> LayerColorStat {
        LayerColorStat out;
        const Layer &layer = *layers[layer_idx];
        for (const LayerRegion *region : layer.regions())
            if (const PrintRegionConfig &config = region->region().config();
                // color_idx == 0 means "don't know" extruder aka the underlying extruder.
                // As this region may split existing regions, we collect statistics over all regions for color_idx == 0.
                color_idx == 0 || config.wall_filament == int(color_idx)) {
                //BBS: the extrusion line width is outer wall rather than inner wall
                out.extrusion_width     = std::max<float>(out.extrusion_width, float(config.outer_wall_line_width));
                out.top_shell_layers    = std::max<int>(out.top_shell_layers, config.top_shell_layers);
                out.bottom_shell_layers = std::max<int>(out.bottom_shell_layers, config.bottom_shell_layers);
                out.small_region_threshold = config.gap_infill_speed.value > 0 ?
                                             // Gap fill enabled. Enable a single line of 1/2 extrusion width.
                                             0.5f * float(config.outer_wall_line_width) :
                                             // Gap fill disabled. Enable two lines slightly overlapping.
                                             float(config.outer_wall_line_width) + 0.7f * Flow::rounded_rectangle_extrusion_spacing(float(config.outer_wall_line_width), float(layer.height));
                out.small_region_threshold = scaled<float>(out.small_region_threshold * 0.5f);
                out.extrusion_spacing = Flow::rounded_rectangle_extrusion_spacing(float(config.outer_wall_line_width), float(layer.height));
                ++ out.num_regions;
            }
        assert(out.num_regions > 0);
        out.extrusion_width = scaled<float>(out.extrusion_width);
        out.extrusion_spacing = scaled<float>(out.extrusion_spacing);
        return out;
    };

There should be more places to handle percents, you can search for the exact name of all these changed parameters through the whole code base to find them.

iFallUpHill · 2023-07-23T06:05:53Z

@SoftFever ~~Right, I think I got them except for this one:~~

Does this block actually do anything? I couldn't find outer_wall_volumetric_speed being used anywhere.

Gcode.cpp

//BBS: calculate the volumetric speed of outer wall. Ignore pre-object setting and multi-filament, and just use the default setting
        {
            float filament_max_volumetric_speed = m_config.option<ConfigOptionFloats>("filament_max_volumetric_speed")->get_at(initial_non_support_extruder_id);
            float outer_wall_line_width = print.default_region_config().outer_wall_line_width.value;
            if (outer_wall_line_width == 0.0) {
                float default_line_width = print.default_object_config().line_width.value;
                outer_wall_line_width = default_line_width == 0.0 ? m_config.nozzle_diameter.get_at(initial_non_support_extruder_id) : default_line_width;
            }
            Flow outer_wall_flow = Flow(outer_wall_line_width, m_config.layer_height, m_config.nozzle_diameter.get_at(initial_non_support_extruder_id));
            float outer_wall_speed = print.default_region_config().outer_wall_speed.value;
            outer_wall_volumetric_speed = outer_wall_speed * outer_wall_flow.mm3_per_mm();
            if (outer_wall_volumetric_speed > filament_max_volumetric_speed)
                outer_wall_volumetric_speed = filament_max_volumetric_speed;
            m_placeholder_parser.set("outer_wall_volumetric_speed", new ConfigOptionFloat(outer_wall_volumetric_speed));
        }

Edit: Also pretty sure the supports don't calculate correctly anymore :'(

iFallUpHill · 2023-07-23T10:12:38Z

@SoftFever Got supports working again, there are a couple of extrusion widths that I think I need to handle still (marked with // TODO for extrusion width PR, but otherwise could you take a look now? I think I got the rest of them.

SoftFever · 2023-07-23T13:45:55Z

@SoftFever Got supports working again, there are a couple of extrusion widths that I think I need to handle still (marked with // TODO for extrusion width PR, but otherwise could you take a look now? I think I got the rest of them.

Sure thing.
Give 1 or 2 days to go through it.

SoftFever · 2023-07-23T13:48:26Z

I was previously worried about multi-extruder scenarios, but since Orca doesn't support multi-extruder yet, I think we can worry about that later.

SoftFever · 2023-07-23T13:51:04Z

src/libslic3r/PrintConfig.cpp

    def->mode = comAdvanced;
-    def->set_default_value(new ConfigOptionFloat(0));
+    def->set_default_value(new ConfigOptionFloatOrPercent(0.4, false));


Would be better to set default to ConfigOptionFloatOrPercent(0, false).
Same for other parameters.

changed all except for line_width

SoftFever · 2023-07-23T14:28:23Z

It's a placeholder. User can access this variable in their custom g-codes

@SoftFever ~~Right, I think I got them except for this one:~~

Does this block actually do anything? I couldn't find outer_wall_volumetric_speed being used anywhere.

Gcode.cpp

//BBS: calculate the volumetric speed of outer wall. Ignore pre-object setting and multi-filament, and just use the default setting
        {
            float filament_max_volumetric_speed = m_config.option<ConfigOptionFloats>("filament_max_volumetric_speed")->get_at(initial_non_support_extruder_id);
            float outer_wall_line_width = print.default_region_config().outer_wall_line_width.value;
            if (outer_wall_line_width == 0.0) {
                float default_line_width = print.default_object_config().line_width.value;
                outer_wall_line_width = default_line_width == 0.0 ? m_config.nozzle_diameter.get_at(initial_non_support_extruder_id) : default_line_width;
            }
            Flow outer_wall_flow = Flow(outer_wall_line_width, m_config.layer_height, m_config.nozzle_diameter.get_at(initial_non_support_extruder_id));
            float outer_wall_speed = print.default_region_config().outer_wall_speed.value;
            outer_wall_volumetric_speed = outer_wall_speed * outer_wall_flow.mm3_per_mm();
            if (outer_wall_volumetric_speed > filament_max_volumetric_speed)
                outer_wall_volumetric_speed = filament_max_volumetric_speed;
            m_placeholder_parser.set("outer_wall_volumetric_speed", new ConfigOptionFloat(outer_wall_volumetric_speed));
        }

Edit: Also pretty sure the supports don't calculate correctly anymore :'(

src/libslic3r/MultiMaterialSegmentation.cpp

iFallUpHill · 2023-07-23T23:19:51Z

Supports work and I fixed the above two comments!

Dustmuffins · 2023-07-24T06:13:20Z

Great feature! Thanks!

src/libslic3r/Config.cpp

SoftFever · 2023-07-25T14:36:03Z

@iFallUpHill
Overall, looks good.
I made some minor fixes/changes to your branch,
Please review: 1e9a4e9

iFallUpHill · 2023-07-25T17:40:18Z

Thanks for the cleanup, definitely looks a lot cleaner now -- only comment left is the one you mentioned about the _line_width check. Feel free to revise to unblock the merge! :D

SoftFever

LGTM

SoftFever · 2023-07-27T15:37:40Z

Merged.
Thank for the great work 👍

1. Previously if there are multiple sharp tails in a layer, some will be missed. To fix this, we should not skip if the current layer is already detected as sharp tails. 2. Do not mistakenly detect sharp horns as sharp tails by only detecting the overhang areas larger than half of the extrusion line width. Github: #1578 Jira: STUDIO-2659 Change-Id: If7ba5c9ae547d3051551aa6fa34eb6214d01a46d

Calculate extrusion width %s as a function of nozzle width, not layer…

509db89

… height

jeremytodd1 mentioned this pull request Jul 23, 2023

layer line width ?! #1574

Closed

handled more width conversions

548a70e

more missing percent handling

18cb687

iFallUpHill force-pushed the extrusion_width_nozzle_percent branch from 7347e72 to 18cb687 Compare July 23, 2023 07:56

even more missed percent handling

daf2069

SoftFever reviewed Jul 23, 2023

View reviewed changes

src/libslic3r/MultiMaterialSegmentation.cpp Outdated Show resolved Hide resolved

even more more extrusion % handling

e9b2d98

iFallUpHill requested a review from SoftFever July 24, 2023 00:54

SoftFever added 4 commits July 25, 2023 19:13

Merge branch 'main' into extrusion_width_nozzle_percent

6fb9b92

Merge branch 'main' into extrusion_width_nozzle_percent

1c9f1ff

some fixes

1e9a4e9

Merge branch 'main' into extrusion_width_nozzle_percent

aaaf9ab

SoftFever reviewed Jul 25, 2023

View reviewed changes

src/libslic3r/Config.cpp Show resolved Hide resolved

Merge branch 'main' into extrusion_width_nozzle_percent

95bb893

SoftFever approved these changes Jul 27, 2023

View reviewed changes

SoftFever merged commit be54f6b into SoftFever:main Jul 27, 2023
0 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calculate extrusion width %s as a function of nozzle width, not layer height #1578

Calculate extrusion width %s as a function of nozzle width, not layer height #1578

iFallUpHill commented Jul 22, 2023 •

edited

Loading

jeremytodd1 commented Jul 23, 2023

SoftFever commented Jul 23, 2023

iFallUpHill commented Jul 23, 2023 •

edited

Loading

iFallUpHill commented Jul 23, 2023 •

edited

Loading

SoftFever commented Jul 23, 2023

SoftFever commented Jul 23, 2023

SoftFever Jul 23, 2023

iFallUpHill Jul 24, 2023

SoftFever commented Jul 23, 2023

iFallUpHill commented Jul 23, 2023 •

edited

Loading

Dustmuffins commented Jul 24, 2023

SoftFever commented Jul 25, 2023

iFallUpHill commented Jul 25, 2023

SoftFever left a comment

SoftFever commented Jul 27, 2023 •

edited

Loading

Calculate extrusion width %s as a function of nozzle width, not layer height #1578

Calculate extrusion width %s as a function of nozzle width, not layer height #1578

Conversation

iFallUpHill commented Jul 22, 2023 • edited Loading

jeremytodd1 commented Jul 23, 2023

SoftFever commented Jul 23, 2023

iFallUpHill commented Jul 23, 2023 • edited Loading

iFallUpHill commented Jul 23, 2023 • edited Loading

SoftFever commented Jul 23, 2023

SoftFever commented Jul 23, 2023

SoftFever Jul 23, 2023

Choose a reason for hiding this comment

iFallUpHill Jul 24, 2023

Choose a reason for hiding this comment

SoftFever commented Jul 23, 2023

iFallUpHill commented Jul 23, 2023 • edited Loading

Dustmuffins commented Jul 24, 2023

SoftFever commented Jul 25, 2023

iFallUpHill commented Jul 25, 2023

SoftFever left a comment

Choose a reason for hiding this comment

SoftFever commented Jul 27, 2023 • edited Loading

iFallUpHill commented Jul 22, 2023 •

edited

Loading

iFallUpHill commented Jul 23, 2023 •

edited

Loading

iFallUpHill commented Jul 23, 2023 •

edited

Loading

iFallUpHill commented Jul 23, 2023 •

edited

Loading

SoftFever commented Jul 27, 2023 •

edited

Loading