Skip to content

Commit

Permalink
Merge pull request #155 from jferreyra-sc/main
Browse files Browse the repository at this point in the history
Improving examples build configs and documentation.
  • Loading branch information
li-feng-sc authored Jul 15, 2024
2 parents 7b6cfc3 + f2143f8 commit cc8190a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
14 changes: 8 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ to build and run Objective-C and Java tests.

### Building and running the mobile example apps

The Android example app can be build with bazel: `bazel build
//examples:android-app`, and then install to a device with `adb install
bazel-bin/examples/android-app.apk`
You need to install the Android SDK 30.0.2 and the NDK 21.4.7075529. You need both `ANDROID_SDK_HOME` and `ANDROID_NDK_HOME` env variables set.
The Android example app can be build with bazel: `bazel build //examples:android-app`,
and then install to a device with `adb install bazel-bin/examples/android-app.apk`

The iOS example app are built with Xcode. Simply open the project in Xcode and
it should work.
Expand Down Expand Up @@ -302,9 +302,11 @@ Notable differences when comparing to the Java/ObjC support:
easily add extension methods (by add functions to prototype) without having to
derive from a base class.

The command to run Wasm/TypeScript unit tests is `bazel run
//test-suite:server-ts`. You will need the `tsc` compiler and the `browserify`
tool to run these tests.
Use `bazel run //test-suite:server-ts` to run the Wasm/TypeScript unit tests.
You will need `npm` and run `npm install` in the `test-suite` folder.
You need as well the `tsc` compiler and the `browserify` tool to run these tests.

To run the examples server: `bazel run //examples:server`

## Async interface support

Expand Down
2 changes: 1 addition & 1 deletion examples/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ android_library(
srcs = glob(["handwritten-src/java/com/dropbox/textsort/*.java"]),
custom_package = "com.dropbox.textsort",
manifest = "android/app/src/main/AndroidManifest.xml",
resource_files = glob(["android/app/src/main/res/**"]),
resource_files = glob(["android/app/src/main/res/**"], exclude=["android/app/src/main/res/.DS_Store"]),
deps = [":textsort-java",],
)

Expand Down
2 changes: 2 additions & 0 deletions examples/ios/TextSort.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "TextSort/TextSort-Prefix.pch";
INFOPLIST_FILE = "TextSort/TextSort-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
LIBRARY_SEARCH_PATHS = "$(inherited)";
PRODUCT_BUNDLE_IDENTIFIER = "Dropbox.${PRODUCT_NAME:rfc1034identifier}";
Expand All @@ -449,6 +450,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "TextSort/TextSort-Prefix.pch";
INFOPLIST_FILE = "TextSort/TextSort-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
LIBRARY_SEARCH_PATHS = "$(inherited)";
PRODUCT_BUNDLE_IDENTIFIER = "Dropbox.${PRODUCT_NAME:rfc1034identifier}";
Expand Down

0 comments on commit cc8190a

Please sign in to comment.