Merge pull request #179 from trblunt/fix-extern-nn-ptrs

Fix extern type usage with non-nullable ptrs
Snapchat · Jul 15, 2024 · 7b6cfc3 · 7b6cfc3
2 parents 9a74ee9 + 6f52b82
commit 7b6cfc3
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/src/source/CppMarshal.scala b/src/source/CppMarshal.scala
@@ -12,7 +12,7 @@
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
-  * 
+  *
   * This file has been modified by Snap, Inc.
   */
 
@@ -117,7 +117,12 @@ class CppMarshal(spec: Spec) extends Marshal(spec) {
     case e: MExtern => e.defType match {
       // Do not forward declare extern types, they might be in arbitrary namespaces.
       // This isn't a problem as extern types cannot cause dependency cycles with types being generated here
-      case DInterface => List(ImportRef("<memory>"), ImportRef(e.cpp.header))
+      case DInterface =>
+        val base = List(ImportRef("<memory>"), ImportRef(e.cpp.header))
+        spec.cppNnHeader match {
+          case Some(nnHdr) => ImportRef(nnHdr) :: base
+          case _ => base
+        }
       case _ => List(ImportRef(resolveExtCppHdr(e.cpp.header)))
     }
     case p: MProtobuf =>
@@ -211,13 +216,23 @@ class CppMarshal(spec: Spec) extends Marshal(spec) {
                 case DInterface => s"${nnType}<${withNamespace(idCpp.ty(d.name))}>"
                 case _ => base(tm.base) + args
               }
+            case e: MExtern =>
+              e.defType match {
+                case DInterface => s"${nnType}<${e.cpp.typename}>"
+                case _ => base(tm.base) + args
+              }
             case MOptional =>
               tm.args.head.base match {
                 case d: MDef =>
                   d.defType match {
                     case DInterface => s"std::shared_ptr<${withNamespace(idCpp.ty(d.name))}>"
                     case _ => base(tm.base) + args
                   }
+                case e: MExtern =>
+                  e.defType match {
+                    case DInterface => s"std::shared_ptr<${e.cpp.typename}>"
+                    case _ => base(tm.base) + args
+                  }
                 case _ => base(tm.base) + args
               }
             case _ => base(tm.base) + args