Skip to content

Prevent FFS from saving ephemeral vars on shutdown #8005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Prevent FFS from saving ephemeral vars on shutdown #8005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/ch/njol/skript/variables/FlatFileStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,10 @@ public final void saveVariables(boolean finalSave) {
*/
@SuppressWarnings("unchecked")
private void save(PrintWriter pw, String parent, TreeMap<String, Object> map) {
if (parent.startsWith(Variables.EPHEMERAL_VARIABLE_PREFIX))
// Skip ephemeral variables
return;

// Iterate over all children
for (Entry<String, Object> childEntry : map.entrySet()) {
Object childNode = childEntry.getValue();
Expand All @@ -471,6 +475,10 @@ private void save(PrintWriter pw, String parent, TreeMap<String, Object> map) {
// Remove variable separator if needed
String name = childKey == null ? parent.substring(0, parent.length() - Variable.SEPARATOR.length()) : parent + childKey;

if (name.startsWith(Variables.EPHEMERAL_VARIABLE_PREFIX))
// Skip ephemeral variables
continue;

try {
// Loop over storages to make sure this variable is ours to store
for (VariablesStorage storage : Variables.STORAGES) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/ch/njol/skript/variables/Variables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public class Variables {
*/
private static final String CONFIGURATION_SERIALIZABLE_PREFIX = "ConfigurationSerializable_";

private static final String EPHEMERAL_VARIABLE_PREFIX = "-";
public static final String EPHEMERAL_VARIABLE_PREFIX = "-";

private final static Multimap<Class<? extends VariablesStorage>, String> TYPES = HashMultimap.create();

Expand Down