Prevent FFS from saving ephemeral vars on shutdown #8005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
requested review from
TheMug06 and
UnderscoreTud
and removed request for
a team
1 task
erenkarakal
approved these changes
Jul 4, 2025
UnderscoreTud
approved these changes
Jul 4, 2025
skriptlang-automation
bot
added
feature-ready
Absolutionism
approved these changes
Jul 4, 2025
APickledWalrus
approved these changes
Jul 4, 2025
skriptlang-automation
bot
added
completed
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
handle FFS's special save method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FFS has a special save method that just pulls all variables and saves them on shutdown, bypassing the normal methods of variable saving. This is poor design but fixing it is out of scope for this pr.
Solution
Adds checks for ephemeral vars in the FFS save treemap method.
Testing Completed
Manual testing
Supporting Information
Completes: #8004
Related: none