Skip to content

Allow Function Names to Start with Underscore #7942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Allow Function Names to Start with Underscore #7942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597be33
change function name pattern
erenkarakal Jun 12, 2025
e737bca
add tests
erenkarakal Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/ch/njol/skript/lang/function/Functions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public static JavaFunction<?> registerFunction(JavaFunction<?> function) {
return function;
}

public final static String functionNamePattern = "[\\p{IsAlphabetic}][\\p{IsAlphabetic}\\p{IsDigit}_]*";
public final static String functionNamePattern = "[\\p{IsAlphabetic}_][\\p{IsAlphabetic}\\p{IsDigit}_]*";

/**
* Loads a script function from given node.
Expand Down
4 changes: 4 additions & 0 deletions src/test/skript/tests/syntaxes/structures/StructFunction.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ local function local() :: number:
local function bar() :: boolean:
return true

local function _blob() :: string:
return "blub"

test "functions":
assert foo() is true with "function return type failed"
assert local() is not 1 with "global function parsed before local function"
assert bar() is true with "local function didn't execute correctly"
assert _blob() is "blub" with "function that starts with underscore didn't execute correctly"