Allow Function Names to Start with Underscore #7942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
Burbulinis and
UnderscoreTud
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Burbulinis
approved these changes
Jun 12, 2025
Efnilite
approved these changes
Jun 12, 2025
skriptlang-automation
bot
added
feature-ready
skriptlang-automation
bot
added
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In languages like Python and JavaScript, starting function names with underscores is a common pattern to indicate that the function is private or meant for internal use only. Skript currently doesn't allow this for seemingly no reason.
Solution
Changes the function name pattern to allow underscores at the beginning
Testing Completed
Added a simple test to
StructFunction.skSupporting Information
Completes: none
Related: none