Fix ExprFunctionCall conversion #4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
bug
TheLimeGlass
approved these changes
Jul 29, 2022
APickledWalrus
approved these changes
Aug 15, 2022
TheLimeGlass
pushed a commit
that referenced
this pull request
Oct 20, 2022
* Change default return type and implement conversion (cherry picked from commit adb687d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #4896, function call expressions were edited to support converting when they were created, but it didn't add conversion support after the ExprFunctionCall was created. This PR adds that and changes the initial return type of ExprFunctionCall to be the either the expected type, or the function return type itself if it is a subclass of the expected types.
Issue reported on Discord,
set {_p}'s velocity to vector({_x}, {_y}, {_z})gave a parse error (not in release, only on master branch).Also edits an assert in ExprVelocity's change method, because it was wrong
Target Minecraft Versions: any
Requirements: none
Related Issues: #4896 (non-fixing)