Fix function converters and plural arguments when single expected #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
bug
APickledWalrus
approved these changes
Jul 15, 2022
There already is a test for this that produces a warning already everytime. This fixes it so it doesn't. |
|
I've added regression tests for both issues |
TheLimeGlass
approved these changes
Jul 18, 2022
bilektugrul
added a commit
to bilektugrul/Skript
that referenced
this pull request
Jul 29, 2022
…cted (SkriptLang#4896)" This reverts commit baccca9.
1 task
TheLimeGlass
pushed a commit
that referenced
this pull request
Oct 20, 2022
) * Make functions error for incorrect argument plurality (single expected, multiple provided) (cherry picked from commit baccca9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented converters in FunctionReference and ExprFunctionCall.
Added an error when using a plural argument on a single parameter (a single argument on a plural parameter is allowed).
Target Minecraft Versions: any
Requirements: none
Related Issues: #4524, #4859