Enable Nullable #2282
Enable Nullable #2282
Conversation
* Disable nullable for all files with #nullable disable Replace order of header and annotation Only use nullable disable in files with errors
|
Wow! Please tell me you did some sort of find/replace for this? |
Adding it in all files works by find and replace. |
| @@ -57,7 +57,7 @@ public override void ToAbgr32(Configuration configuration, ReadOnlySpan<Abgr32> | |||
| { | |||
| Vector4Converters.RgbaCompatible.ToVector4(configuration, this, sourcePixels, destVectors, modifiers.Remove(PixelConversionModifiers.Scale)); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Any idea what caused these changes?
We should probably add #nullable disable to all T4 templates at some point.
There was a problem hiding this comment.
No clue. I reverted a bunch of changes. Probably overlooked this one.
I can only imagine that opening the file in rider on Mac caused this.
|
I broke your PR. Sorry! |
I fixed it. One build step is failing. I am not able to trigger it. For me the error seems unrelated. @JimBobSquarePants Could you have a look please? |
|
@JimBobSquarePants Is there anything blocking this pr? Anything I can do? Or you just waiting for a good "moment" to merge? |
|
Sorry for the delay. Yep everything looks good. Just trying to get #2276 in first as it will be easier to merge this one after than the other way round. |
Add nullable disable to ImageDecoder
|
@JimBobSquarePants I added another nullable disable. So I should be finished now |
Prerequisites
Description
Enabled nullable analysis.
Disabled in all files where errors happened.
First step of #2231