Skip to content

Enable Nullable Reference Types #2231

Closed
@JimBobSquarePants

Description

@JimBobSquarePants

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

ImageSharp version

v3 alpha +

Other ImageSharp packages and versions

NA

Environment (Operating system, version and so on)

NA

.NET Framework version

NA

Description

Following some initial investigation, it appears adding Nullable Reference Types to the solution is not as much work as I initially feared.

  • Only 824 errors were reported
  • 119 can be ignored in AotCompilerTools by explicitly disabling the analysis there via #nullable disable
  • Most of the errors can be fixed by updating equality overrides which are missing attributes.

Enabling analysis requires adding the following to individual .csproj files

<NullableContextOptions>enable</NullableContextOptions>
<Nullable>enable</Nullable>

We should consider doing this for V3.

Steps to Reproduce

NA

Images

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions