Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

.NET 5 bring a native InternalVisibleTo target implementation that is incompatible with our current implementation. The fix is simple, update our property to use the same Key attribute rather than PublicKey.

Tested using Visual Studio 16.8.0 Preview 2.1 and .NET 5 SDK 5.0.100-preview.8.20417.9

See issue first identified by @Sergio0694

#1314 (comment)

And explanation from @tannergooding

dotnet/sdk#13289 (comment)

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         690      690           
  Lines       30973    30973           
  Branches     3511     3511           
=======================================
  Hits        25639    25639           
  Misses       4613     4613           
  Partials      721      721           
Flag Coverage Δ
#unittests 82.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd05204...e1a15c5. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JimBobSquarePants JimBobSquarePants merged commit c9e4d05 into master Sep 1, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-net5-build branch September 1, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants