Skip to content

Conversation

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Sep 18, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Same thing as SixLabors/ImageSharp#1337. My Rider is configured with .NET 5 SDK so I need this now.

@antonfirsov
Copy link
Member Author

No idea why does this fail for 2.1 😞

@JimBobSquarePants
Copy link
Member

@antonfirsov The issue is unrelated. GitHub have changed the images.
SixLabors/ImageSharp@398e3a7#diff-c2079db070ee682627c591c8361a58c2

We also need to update CodeCov
SixLabors/ImageSharp@f0ed1b7#diff-c2079db070ee682627c591c8361a58c2

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          77       77           
  Lines        5079     5079           
  Branches     1056     1056           
=======================================
  Hits         3408     3408           
  Misses       1444     1444           
  Partials      227      227           
Flag Coverage Δ
#unittests 67.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a324c4f...f6b3d94. Read the comment docs.

@tocsoft tocsoft merged commit 799d6af into master Sep 18, 2020
@JimBobSquarePants JimBobSquarePants deleted the af/fix-net5-build branch September 18, 2020 10:47
@antonfirsov
Copy link
Member Author

@JimBobSquarePants thanks!

@JimBobSquarePants
Copy link
Member

No worries. I should fix Fonts also, will do it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants