Skip to content

WIP #12 Refactory tiff structures, decoder classes#1322

Closed
IldarKhayrutdinov wants to merge 1763 commits intoSixLabors:tiff-codecfrom
IldarKhayrutdinov:tiff-codec
Closed

WIP #12 Refactory tiff structures, decoder classes#1322
IldarKhayrutdinov wants to merge 1763 commits intoSixLabors:tiff-codecfrom
IldarKhayrutdinov:tiff-codec

Conversation

@IldarKhayrutdinov
Copy link
Contributor

@IldarKhayrutdinov IldarKhayrutdinov commented Aug 20, 2020 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Deep refactoring and improves for tiff classes.
And:

  • Synch with master.
  • Support multi framing.
  • Using Metadata\Profiles\Exif\ types instead their duplicate tag types (moved to __obsolete directory).
  • Implement useful Metadata classes.
  • Add extensions.
  • Test coverage.

brianpopow and others added 30 commits April 29, 2020 18:48
@brianpopow
Add tests for make transparent black option
a86713f
@brianpopow
MakeTransparentBlack option now work with all png color type
8ca9b97
@brianpopow
Merge branch 'master' into PNGOptimisation
c386f9d
@antonfirsov
use only netcoreapp3.1
1736596
@antonfirsov
add failing test for global quantization
c049429
@antonfirsov
BufferArea -> BufferRegion, introduce PixelSamplingStrategy
3e2f7dd
@antonfirsov
FrameQuantizer<T> -> Quantizer<T>
b6208b9
@antonfirsov
fix style issue
8551b8b
@antonfirsov
BuildPaletteAndQuantizeFrame, use IPixelSamplingStrategy in GifEncoder
097b9dd
@antonfirsov
Revert "use only netcoreapp3.1"
5db749e 
This reverts commit 1736596.
@brianpopow @JimBobSquarePants
ExcludeAll = ~None
200ef9f 
Co-Authored-By: James Jackson-South <james_south@hotmail.com>
@brianpopow
Improve exclude filter test to also check presence of expected chunks
f9c2f6a
@JimBobSquarePants
Merge pull request SixLabors#1193 from SixLabors/af/extended-quantiza…
0c6f0dc 
…tion

Efficient global quantization in GifEncoder
@JimBobSquarePants
Merge branch 'master' into release/rc-1
749ca71
@JimBobSquarePants
BufferRegion => Buffer2DRegion
bedd0a9
@JimBobSquarePants
Merge pull request SixLabors#1194 from SixLabors/js-buffer2dregion
1ac4042 
BufferRegion => Buffer2DRegion
@JimBobSquarePants
Merge branch 'master' into release/rc-1
2e3ebb4
@JimBobSquarePants
Update source license info.
4e3dce1
@JimBobSquarePants
Merge pull request SixLabors#1182 from SixLabors/release/rc-1
b44008e 
Release RC1
@brianpopow
Remove not needed image parameter from CalculateBitDepth
0f581ab
@brianpopow
Add IgnoreMetadata to the png encoder options
bc7eb27
@brianpopow
Add PngTransparentColorBehavior enum
ec3656f
@brianpopow
Merge branch 'master' into PNGOptimisation
749f68a
@brianpopow
Switched Preserve to be 0 for PngTransparentColorBehavior enum
129b639
@brianpopow
Rename PngTransparentColorBehavior to PngTransparentColorMode
b69d772
@tocsoft
Add Async APIs to IImageEncoder and IImageDecoder
9bbd505
@tocsoft
Save async tests
4d95e2e
@tocsoft
implement Load Async apis
dff8ab6
@tocsoft
IdentifyAsync
c69683e 
+ stylecop
@brianpopow
Change Scanlines and SamplesPerLine from short to int
9415e58
antonfirsov and others added 16 commits August 4, 2020 02:07
@antonfirsov
one leftover
21d94f2
@JimBobSquarePants @antonfirsov
Update src/ImageSharp/Common/Helpers/SimdUtils.cs
c6d4dd9 
Co-authored-by: Anton Firszov <antonfir@gmail.com>
@JimBobSquarePants
Merge pull request SixLabors#1299 from SixLabors/js/better-edge-detec…
586d99e 
…tion

Better Edge Detection API
@JimBobSquarePants
Merge branch 'master' into af/cancellation
5a4aea8
@JimBobSquarePants
Minor fixes.
e707a8d
@JimBobSquarePants
Merge pull request SixLabors#1296 from SixLabors/af/cancellation
521fae3 
Cancellable codec API, and overloads for loading/saving
@JimBobSquarePants
Merge branch 'master' into js/jpeg-decode-perf
1eaaf1a
@JimBobSquarePants
Merge pull request SixLabors#1303 from SixLabors/js/jpeg-decode-perf
a31a541 
Optimize jpeg decoder based on traces.
@IldarKhayrutdinov
Merge pull request #8 from SixLabors/master
efe77a8 
synch from master
@IldarKhayrutdinov
Merge remote-tracking branch 'origin/master' into tiff-codec_refactor…
97d14c4 
…y__tmp
@IldarKhayrutdinov
Deep refactoring and improves for tiff classes.
1ea22f3 
In particular:
* Support multi framing.
* Using Metadata\Profiles\Exif\ types instead their duplicate tag types (moved to __obsolete directory).
* Implement useful Metadata classes.
* Add extensions.
* Test coverage.
@IldarKhayrutdinov
Rename
2d7ab96
@IldarKhayrutdinov
Deep refactoring and improves for tiff classes.
dcf2bac 
* Add and improve tests, benchmark.
@IldarKhayrutdinov
Lzw and deflate bug report.
1db01d0
@IldarKhayrutdinov
Update license.
4548452
@IldarKhayrutdinov
Update .gitattributes
8867f00
@IldarKhayrutdinov IldarKhayrutdinov changed the title #12 Refactory tiff structures, decoder classes SixLabors#12 Refactory tiff structures, decoder classes Aug 20, 2020
@antonfirsov antonfirsov marked this pull request as ready for review August 20, 2020 14:52
@IldarKhayrutdinov IldarKhayrutdinov changed the title SixLabors#12 Refactory tiff structures, decoder classes WIP #12 Refactory tiff structures, decoder classes Aug 20, 2020
@IldarKhayrutdinov IldarKhayrutdinov marked this pull request as draft August 20, 2020 16:17
@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Aug 20, 2020

I think something went horribly wrong with the tiff-codec branch when this PR #986 was merged.

We won't be able to continue as-is as it's now impossible to update the branch from master without issues.

I've created a new tiff branch containing all the existing development but based upon the current master.

If you can please apply your changes to the relevant files to a fork based upon that branch we'll be able to review them and continue.

Sorry for the inconvenience.

@IldarKhayrutdinov
Copy link
Contributor Author

IldarKhayrutdinov commented Aug 21, 2020

@JimBobSquarePants @antonfirsov Yeah, this brunch is too far behind the master ... thanks for the help 😌

@IldarKhayrutdinov IldarKhayrutdinov marked this pull request as ready for review August 27, 2020 18:23
@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Aug 27, 2020

I see you've marked this ready for review but we cannot review and merge it in it's current state.

I suggest, instead, that you close this PR and create a new one based upon the branch I provided.

@IldarKhayrutdinov
Copy link
Contributor Author

IldarKhayrutdinov commented Aug 27, 2020 •
edited
Loading

@JimBobSquarePants sorry, it was by chance, I preparing a new PR

@IldarKhayrutdinov IldarKhayrutdinov marked this pull request as draft August 27, 2020 19:08
@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Aug 27, 2020

@IldarKhayrutdinov Awesome! 👍

@IldarKhayrutdinov
Copy link
Contributor Author

IldarKhayrutdinov commented Aug 28, 2020

@antonfirsov @JimBobSquarePants as discussed in gitter, I create new PR #1330 and I close this PR

@IldarKhayrutdinov IldarKhayrutdinov deleted the tiff-codec branch August 28, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@IldarKhayrutdinov @JimBobSquarePants @pekspro @brianpopow @antonfirsov @tocsoft @Jaben @shaggygi @Turnerj @wilka