Skip to content

Release RC1#1182

Merged
JimBobSquarePants merged 17 commits intomasterfrom
release/rc-1
Apr 30, 2020
Merged

Release RC1#1182
JimBobSquarePants merged 17 commits intomasterfrom
release/rc-1

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Apr 22, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Consolidation for the RC1 Release.

TODO:

  • Update SharedInfrastructure sub module and update solution-wide license details.
  • Review Nuspec icon settings to ensure our branding is consistent.

For review.

No Code changes compared with master. All diffs are license header changes.

https://github.com/SixLabors/ImageSharp/blob/4e3dce1e95a57cd2a0636bbbd2784717ad994556/README.md

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #1182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         694      694           
  Lines       30046    30046           
  Branches     3397     3397           
=======================================
  Hits        24813    24813           
  Misses       4535     4535           
  Partials      698      698           
Flag Coverage Δ
#unittests 82.58% <ø> (ø)
Impacted Files Coverage Δ
src/ImageSharp/Advanced/AdvancedImageExtensions.cs 53.33% <ø> (ø)
...c/ImageSharp/Advanced/ParallelExecutionSettings.cs 100.00% <ø> (ø)
...mageSharp/Advanced/ParallelRowIterator.Wrappers.cs 92.72% <ø> (ø)
src/ImageSharp/Advanced/ParallelRowIterator.cs 100.00% <ø> (ø)
src/ImageSharp/Color/Color.Conversions.cs 86.66% <ø> (ø)
src/ImageSharp/Color/Color.NamedColors.cs 100.00% <ø> (ø)
src/ImageSharp/Color/Color.WebSafePalette.cs 100.00% <ø> (ø)
src/ImageSharp/Color/Color.WernerPalette.cs 100.00% <ø> (ø)
src/ImageSharp/Color/Color.cs 95.74% <ø> (ø)
src/ImageSharp/ColorSpaces/CieLab.cs 95.45% <ø> (ø)
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac4042...4e3dce1. Read the comment docs.

@tocsoft
Copy link
Member

tocsoft commented Apr 22, 2020

don't forget we also need to update the header comment is all the source files with the updated license... or just remove the licensing message altogether.

@JimBobSquarePants
Copy link
Member Author

don't forget we also need to update the header comment is all the source files with the updated license... or just remove the licensing message altogether.

That will be dealt with by https://github.com/SixLabors/SharedInfrastructure/pull/8/files#diff-2f84bd32c9442743b5a7c824567a610cR13

README.md Outdated
- ImageSharp is licensed under the [GNU Affero General Public License v3](https://www.gnu.org/licenses/agpl-3.0)
- An alternative Commercial License can be purchased for Closed Source projects and applications.
Please visit https://sixlabors.com/pricing for details.
- Open Source projects who whave taken a dependency on ImageSharp prior to adoption of the AGPL v3 license are permitted to use ImageSharp (including all future versions) under the previous [Apache 2.0 License](https://opensource.org/licenses/Apache-2.0).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on this line, whave should be have right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks!

@JimBobSquarePants JimBobSquarePants changed the title WIP : Release RC1 Release RC1 Apr 30, 2020
@@ -1,6 +1,6 @@
<h1 align="center">

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimBobSquarePants JimBobSquarePants marked this pull request as ready for review April 30, 2020 21:10
@JimBobSquarePants JimBobSquarePants requested a review from a team April 30, 2020 21:10
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JimBobSquarePants JimBobSquarePants merged commit b44008e into master Apr 30, 2020
@JimBobSquarePants JimBobSquarePants deleted the release/rc-1 branch April 30, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants