Skip to content

Conversation

@tocsoft
Copy link
Member

@tocsoft tocsoft commented Jan 12, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

ImageSharp.Drawing has been removed form the main repository and moved over to https://github.com/SixLabors/ImageSharp.Drawing (which also has had Shapes merged into it too).

This PR is just removing all drawing extensions minus the DrawImage() one (as I feel its important enough to be required without vector drawing etc.) that make ImageSharp.Drawing just the vector/text/brush based items.

@antonfirsov
Copy link
Member

What's the fate of Drawing benchmarks? (ImageSharp.Benchmarks/Drawing/** - can't find them in the new repo)
Don't we consider them valuable any longer, or are they left out by mistake?

@JimBobSquarePants
Copy link
Member

@antonfirsov I'll open a separate PR in Drawing to add the benchmarks

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1924acb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1082   +/-   ##
=========================================
  Coverage          ?   87.33%           
=========================================
  Files             ?     1131           
  Lines             ?    50041           
  Branches          ?     3677           
=========================================
  Hits              ?    43703           
  Misses            ?     5550           
  Partials          ?      788
Impacted Files Coverage Δ
....Tests/TestUtilities/Tests/TestEnvironmentTests.cs 70.58% <ø> (ø)
...rocessing/Processors/Drawing/DrawImageProcessor.cs 100% <ø> (ø)
...awing/Processing/Extensions/DrawImageExtensions.cs 95.65% <ø> (ø)
tests/ImageSharp.Tests/GraphicsOptionsTests.cs 100% <ø> (ø)
...ts/ImageSharp.Tests/Image/ImageTests.WrapMemory.cs 83.33% <100%> (ø)
tests/ImageSharp.Tests/Drawing/DrawImageTests.cs 98.97% <100%> (ø)
...ests/TestUtilities/ImageProviders/SolidProvider.cs 58.62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1924acb...9a478d2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants