Skip to content

Conversation

@SimonCropp
Copy link
Contributor

looks like mono is not being used? if it is then close this

But if it isnt this PR will speed up your travis builds

@JimBobSquarePants
Copy link
Member

I've restarted the Travis build here. The first run had some Gdip errors, so I'm hoping it was a one-time issue.

@JimBobSquarePants
Copy link
Member

@SimonCropp Looks like this won't work as it is.

System.DllNotFoundException : Unable to load DLL 'libgdiplus': The specified module could not be found.

https://travis-ci.org/SixLabors/ImageSharp/builds/602052654#L484

Updating to the latest System.Drawing.Common should hopefully fix it.
dotnet/core#2746

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments regarding missing libgdiplus

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1032 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   89.87%   89.87%   +<.01%     
==========================================
  Files        1103     1103              
  Lines       48896    48897       +1     
  Branches     3441     3441              
==========================================
+ Hits        43944    43945       +1     
  Misses       4249     4249              
  Partials      703      703
Impacted Files Coverage Δ
.../PixelFormats/PixelBlenders/PorterDuffFunctions.cs 100% <0%> (ø) ⬆️
...rc/ImageSharp/PixelFormats/PixelBlender{TPixel}.cs 100% <0%> (ø) ⬆️
...ats/PixelBlenders/PorterDuffFunctions.Generated.cs 38.02% <0%> (ø) ⬆️
...ts/PixelBlenders/DefaultPixelBlenders.Generated.cs 77.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2925668...a1a6032. Read the comment docs.

@SimonCropp
Copy link
Contributor Author

i pushed System.Drawing.Common 4.6 to check

@JimBobSquarePants
Copy link
Member

Same issue I'm afraid. I've cancelled the AppVeyor build to stop it blocking others.

@SimonCropp
Copy link
Contributor Author

trying this dotnet/core#2746 (comment)

@JimBobSquarePants
Copy link
Member

Fixed with #1082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants