-
-
Notifications
You must be signed in to change notification settings - Fork 888
opt out of mono on travis #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've restarted the Travis build here. The first run had some Gdip errors, so I'm hoping it was a one-time issue. |
|
@SimonCropp Looks like this won't work as it is. https://travis-ci.org/SixLabors/ImageSharp/builds/602052654#L484 Updating to the latest System.Drawing.Common should hopefully fix it. |
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments regarding missing libgdiplus
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
+ Coverage 89.87% 89.87% +<.01%
==========================================
Files 1103 1103
Lines 48896 48897 +1
Branches 3441 3441
==========================================
+ Hits 43944 43945 +1
Misses 4249 4249
Partials 703 703
Continue to review full report at Codecov.
|
|
i pushed System.Drawing.Common 4.6 to check |
|
Same issue I'm afraid. I've cancelled the AppVeyor build to stop it blocking others. |
|
trying this dotnet/core#2746 (comment) |
|
Fixed with #1082 |
looks like mono is not being used? if it is then close this
But if it isnt this PR will speed up your travis builds