Skip to content

small improvements on the PorterDuff functions #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2019
Merged

small improvements on the PorterDuff functions #1042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4bb9cb
small improvements on the PorterDuff functions
jongleur1983 Oct 31, 2019
f076b30
Merge branch 'master' into PorterDuffImprovement
JimBobSquarePants Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ImageSharp/PixelFormats/PixelBlenders/PorterDuffFunctions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public static Vector4 Over(Vector4 destination, Vector4 source, Vector4 blend)
float srcW = source.W - blendW;

// calculate final alpha
float alpha = dstW + srcW + blendW;
float alpha = dstW + source.W;

// calculate final color
Vector4 color = (destination * dstW) + (source * srcW) + (blend * blendW);
Expand All @@ -191,7 +191,7 @@ public static Vector4 Atop(Vector4 destination, Vector4 source, Vector4 blend)
float dstW = destination.W - blendW;

// calculate final alpha
float alpha = dstW + blendW;
float alpha = destination.W;

// calculate final color
Vector4 color = (destination * dstW) + (blend * blendW);
Expand Down