small improvements on the PorterDuff functions #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line 167:
dstW + srcW + blendW
= dstW + (src.W - blendW) + blendW
= destination.W + source.W - blendW + blendW
= destination.W + source.W
line 194:
dstW + blendW
= (destination.W - blendW) + blendW
= destination.W - blendW + blendW
= destination.W
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 1104 1104
Lines 48948 48948
Branches 3452 3452
=======================================
Hits 43987 43987
Misses 4250 4250
Partials 711 711
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the changes:
line 167:
dstW + srcW + blendW
= dstW + (source.W - blendW) + blendW
= dstW + source.W - blendW + blendW
= dstW + source.W
line 194:
dstW + blendW
= (destination.W - blendW) + blendW
= destination.W - blendW + blendW
= destination.W
Prerequisites
Description
removes two additions that are not necessary.