New convention for Consume project #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation commit for a new convention in Consume.cs. New convention will use sorted methods, so take all methods in the class and sort it. Also move all "language features" (i.e. everything that isn't obvious method call) to one place, at the top.
The change has moved methods from constructor to individual methods. New convention says usage shoudl be demonstrated in a method with name of a type plus suffix `_Methods`.
|
looks great. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #211 (comment).
I have made a new convention for API usages in Consume project, added it to
contributing.mdand modifiedConsume.csaccording to the new convention.Generally speaking, because Consume project is there only to check API compiles in old runtimes (net461 ect.), I think shorter code is preferable. The PR therefore puts method calls to method-per-type in a class (e.g.
Span_MethodsorInt_Methods). I am using suffix to avoid naming issues where method and type have same name.