Add a Dictionary{TKey,}.TryAdd #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thansk i will deploy this now
happy to accept any PRs that improve this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dictionary{TKey, TValue} method to the polyfill.
Thanks for the library, it helped me a lot.
BTW, you might want to expand documenation in contributing.md about how to add (how usage should look like) usage of API to
Consumeproject. There is a main chunk of code in the ctor and then there are many unreferenced methods (generally in form {ClassName}{MethodName}). I have just added a method next to other ones for Dictionary in ctor, but it might be good to define pattern how it should be implemented.