CRL Vessel #202
CRL Vessel #202
Conversation
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Thanks @rjrios915! Please have a look at the reviews. There are a bunch of changes that shouldn't be in here which make it hard to see the actual novelties of this PR. Mainly, these are:
applications: a bunch of formatting changes (that we don't pick up on becauseclang-formatonly checks thesrcfolder)- unintended changes regarding the cycle length that are likely from incorrectly merging conflicting files from another PR
In the future, when opening a PR, please have a look at the Files changed tab on the GitHub PR. There should be only changes that you intend to make. If you notice any other modified files, reset them with git checkout master <path-to-file>.
There was a problem hiding this comment.
exclude applications folder from commit, those are all formatting changes
There was a problem hiding this comment.
this shouldn't be deleted, probably result of a merge conflict
There was a problem hiding this comment.
this shouldn't be deleted, probably result of a merge conflict
There was a problem hiding this comment.
this shouldn't be deleted, probably result of a merge conflict
There was a problem hiding this comment.
none of the files in test_interface should be modified. checkout from master
2 participants
Added a CRL Vessel Block
Current situation
I added a new blood vessel ordered capacitor, resistor, inductor.
Release Notes
Documentation
Added Doxygen for new block.
Testing
Added both analytical and closed loop test validated against previous solutions.
Code of Conduct & Contributing Guidelines