-
Notifications
You must be signed in to change notification settings - Fork 35
Piecewise Chamber and Valve #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rjrios915
wants to merge
44
commits into
SimVascular:master
Choose a base branch
from
rjrios915:PiecewiseChamberAndValve
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into RegChamber
… into RickyRegChamber
mrp089
requested changes
Nov 25, 2025
Member
mrp089
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjrios915, please review all files/folders in this PR and check if you actually intend on modifying them (see comments for #202).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Piecewise Chamber and Valve
Current situation
I developed I model based on the equations outline in Regazzoni's heart model which required the implementation of a new heart block as well as new values.1
Release Notes
Documentation
Added Doxygen for all blocks.
Testing
Added a closed loop test case validated against an existing model.
Code of Conduct & Contributing Guidelines