Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORY] Move union-api & gothic-api linking to FetchContent #49

Closed
3 tasks
piotrmacha opened this issue Aug 29, 2024 · 0 comments
Closed
3 tasks

[STORY] Move union-api & gothic-api linking to FetchContent #49

piotrmacha opened this issue Aug 29, 2024 · 0 comments
Labels
story Task or feature that needs to be done
Milestone
v0.4.0 Just Works™

Comments

@piotrmacha
Copy link
Member

Story
As a Developer, I want to fetch union-api & gothic-api CMake targets using FetchContent, so we don't have to maintain our custom targets.

Definition of Done

  • Use FetchContent to download union-api and gothic-api from upstream repostiories
  • Link union-api and gothic-api from the official targets
  • Setup more restrictive compiler warning/error handling
@piotrmacha piotrmacha added the story Task or feature that needs to be done label Aug 29, 2024
@piotrmacha piotrmacha added this to the v0.4.0 Just Works™ milestone Aug 29, 2024
piotrmacha added a commit that referenced this issue Oct 19, 2024
@piotrmacha
#49 Include union-api and gothic-api using FetchContent, enable /W4 /…
07e75a3 
…WX flags
piotrmacha added a commit that referenced this issue Oct 19, 2024
@piotrmacha
#48 General tidying, null-safety, better error reporting #49 union-ap…
3d59b19 
…i & gothic-api included using FetchContent, /W4 /WX flags set (#52)

* #48 Add additional null-checks and perform general tidying of the project

* #49 Include union-api and gothic-api using FetchContent, enable /W4 /WX flags

* Ignore warning C4740: flow in or out of inline asm code suppresses global optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story Task or feature that needs to be done
Projects
None yet
Milestone
v0.4.0 Just Works™
Development

No branches or pull requests
1 participant
@piotrmacha