Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Invalid configuration may lead to a crash because of null values #48

Closed
piotrmacha opened this issue Aug 29, 2024 · 0 comments
Closed

[BUG] Invalid configuration may lead to a crash because of null values #48

piotrmacha opened this issue Aug 29, 2024 · 0 comments
Assignees
@piotrmacha
Labels
bug Something isn't working SEV2 High severity
Milestone
v0.4.0 Just Works™

Comments

@piotrmacha
Copy link
Member

Describe the bug

Some code paths don't check the validity of pointers and validity of configuration that may lead to a crash.

  • Add null checks in every possible code path where the pointer could be null
  • Add warnings/errors to the console

To Reproduce
Steps to reproduce the behavior:
1.

Expected behavior
...

Screenshots
...

Gothic Version
Gothic 1, Gothic Sequel, Gothic II Classic, Gothic II NotR

zBassMusic Version
v0.3.4

Union Version
Union 1.0m

Additional context
...
@piotrmacha piotrmacha added the bug Something isn't working label Aug 29, 2024
@piotrmacha piotrmacha self-assigned this Aug 29, 2024
@piotrmacha piotrmacha added this to the v0.4.0 Just Works™ milestone Aug 29, 2024
@piotrmacha piotrmacha added the SEV2 High severity label Aug 29, 2024
piotrmacha added a commit that referenced this issue Oct 19, 2024
@piotrmacha
#48 Add additional null-checks and perform general tidying of the pro…
7d5934a 
…ject
piotrmacha added a commit that referenced this issue Oct 19, 2024
@piotrmacha
#48 General tidying, null-safety, better error reporting #49 union-ap…
3d59b19 
…i & gothic-api included using FetchContent, /W4 /WX flags set (#52)

* #48 Add additional null-checks and perform general tidying of the project

* #49 Include union-api and gothic-api using FetchContent, enable /W4 /WX flags

* Ignore warning C4740: flow in or out of inline asm code suppresses global optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotrmacha piotrmacha

Labels
bug Something isn't working SEV2 High severity
Projects
None yet
Milestone
v0.4.0 Just Works™
Development

No branches or pull requests
1 participant
@piotrmacha