Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check user permissions before displaying #6

Open
Sigafoos opened this issue Sep 2, 2020 · 3 comments
Open

Check user permissions before displaying #6

Sigafoos opened this issue Sep 2, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Sigafoos
Copy link
Owner

Sigafoos commented Sep 2, 2020

Wouldn't want PCs to be able to tell the BBEG is a member of their faction before the big reveal...

@bryancasler
Copy link

Love this module but this is a big one for me. Until this is about to be done, another solution might be too restrict the cross reference visibility to only the GM. This way it's there, but no possibility of spoilers. Thoughts?

@Sigafoos
Copy link
Owner Author

Sigafoos commented Sep 7, 2020

It shouldn’t be too hard to implement this (and about the same amount of difficulty as making everything GM only). I’ve been putting all my effort into #7, which is proving more difficult than it should be. My thinking is that right now you don’t have all the links so it’s pointless to enable no matter what.

@Sigafoos Sigafoos added the bug Something isn't working label Sep 7, 2020
@Benjaneer
Copy link

I'd be satisfied if the links are formatted "secret" then the reference to be formatted secret too, if the link is not secret then the reference doesn't need to be either (not sure if that would be more or less complicated than checking the linked object permissions).

jtracey added a commit to jtracey/journal-backlinks that referenced this issue Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants