Skip to content

Adding the sift-integration test for the sift-java workflow #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Adding the sift-integration test for the sift-java workflow #93

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
17d250b
Adding the java integration test for sift-java repo
Jun 22, 2023
05b2c79
extract the contents of the .jar file directly into the app/libs/
Jun 27, 2023
c7951e3
Removing hardcoded versioning.
Jun 28, 2023
da8b331
Running the integration only on master branch.
Jun 28, 2023
e8b84cd
Fixing the version to pick dynamically.
Jun 28, 2023
2a34f34
Making the integration build only on master branch
Jun 28, 2023
289d87e
Making the integration build only on master branch
Jun 29, 2023
19726c8
Making the integration build only on master branch
Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 42 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ commands:
done < github_slack
rm github_slack

context: &context
- slack-templates
- slack_Oauth
- Github_Slack_UserMapping

jobs:
build:
docker:
Expand Down Expand Up @@ -62,11 +67,44 @@ jobs:
- slack/notify:
<<: *slack_notify

java_integration:
docker:
- image: circleci/openjdk:8-jdk
working_directory: ~/repo

environment:
TERM: dumb
GRADLE_OPTS: -Dorg.gradle.project.sonatypeUsername=username -Dorg.gradle.project.sonatypePassword=password

steps:
- checkout
- export_slack_id
- run:
name: Build and packaged sift-java
command: ./gradlew distZip

- add_ssh_keys:
fingerprints:
- "4c:c7:1d:f2:95:87:3c:f6:61:4e:46:5a:c8:2a:d7:c9"

- run:
name: Clone sift-java-integration-app and extract sift-java
command: |
export GIT_SSH_COMMAND='ssh -i ~/.ssh/id_rsa_4cc71df295873cf6614e465ac82ad7c9'
git clone git@github.com:SiftScience/sift-java-integration-app.git
cd sift-java-integration-app
unzip -j ../build/distributions/sift-java-3.10.0.zip -d app/libs/
Copy link

@btusakul-sift btusakul-sift Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build shouldn't include hard-coded version of the package that it is building.

Copy link
Contributor Author

@VinayakGadad VinayakGadad Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to dynamically pick the versions from gradle properties.


- run:
name: Running tests in sift-java-integration-app
command: |
cd sift-java-integration-app
./gradlew test

workflows:
sift-java:
jobs:
- build:
context:
- slack-templates
- slack_Oauth
- Github_Slack_UserMapping
context: *context
- java_integration:
context: *context