Adding the sift-integration test for the sift-java workflow #93
Conversation
VinayakGadad
force-pushed
the
CI-11587-build-integration-testing-app-into-ci-pipeline
branch
from
5920d8b to
17d250b
Compare
VinayakGadad
changed the title
.circleci/config.yml
Outdated
| export GIT_SSH_COMMAND='ssh -i ~/.ssh/id_rsa_4cc71df295873cf6614e465ac82ad7c9' | ||
| git clone git@github.com:SiftScience/sift-java-integration-app.git | ||
| cd sift-java-integration-app | ||
| unzip -j ../build/distributions/sift-java-3.10.0.zip -d app/libs/ |
There was a problem hiding this comment.
The build shouldn't include hard-coded version of the package that it is building.
There was a problem hiding this comment.
Changed it to dynamically pick the versions from gradle properties.
.circleci/config.yml
Outdated
| name: Clone sift-java-integration-app and extract sift-java | ||
| command: | | ||
| export GIT_SSH_COMMAND='ssh -i ~/.ssh/id_rsa_4cc71df295873cf6614e465ac82ad7c9' | ||
| version=$(./gradlew properties -q | grep "version:" | awk '{print $2}') |
There was a problem hiding this comment.
I'd suggest editing the grep to use regex and match ^version: . This way, you won't get multiple matches if there are other property names that have version as a suffix.
There was a problem hiding this comment.
When I ran the ./gradlew properties -q it had only 1 version variable. It makes sense if there are multiple matches.
I have updated the grep accordingly.
There was a problem hiding this comment.
It's a small change to make the build more robust. Have to think about future-proofing where you can.
Purpose:
Technical overview:
Testing plan:
Deployment plan: