Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Add intl support with test + remove windows build #22

Merged
merged 12 commits into from
Nov 16, 2021
Merged

Conversation

genevieve
Copy link

@genevieve genevieve commented Oct 28, 2021

Context

We want internationalization support provided by V8 by default.

Changes

  • The mac + ubuntu binaries have been updated with ICU enabled and the tests pass.
  • The windows binary build + test CI parts have been commented out. We can't build the windows binary with ICU enabled because of a dependency. There are more details below, but I believe, for now, we can have our fork build only ubuntu/mac until we have support for building the windows binary described here

Old Windows Notes

  • The windows binary has yet to be built but it needs python2 to run the icu assemble script and it needs the __init__.py files in all directories of the path for v8.build.util.lastchange to be imported into our build script.

If we do not want to embed ICU data into the v8 binary, we can revert the windows python2 stuff but we then need to figure out how to get the path to the v8 executable from v8go.cc so we can run the v8 function InitializeICUDefaultLocation(v8-exec-path) which will initialize icu and find the icu data file next to wherever the executable is located.

@genevieve genevieve force-pushed the gl-icudata branch 3 times, most recently from d700232 to fab2f7b Compare October 28, 2021 23:00
deps/build.py Outdated Show resolved Hide resolved
intl_test.go Show resolved Hide resolved
@genevieve genevieve changed the title Add intl support with test Add intl support with test + remove windows build Nov 3, 2021
@genevieve genevieve marked this pull request as ready for review November 3, 2021 03:18
Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com>
@genevieve genevieve merged commit 0e8bfdb into master Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants