This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
forked from rogchap/v8go
-
Notifications
You must be signed in to change notification settings - Fork 3
Add intl support with test + remove windows build #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 static library for macos-latest
V8 static library for ubuntu-18.04
genevieve
force-pushed
the
gl-icudata
branch
3 times, most recently
from
October 28, 2021 23:00
d700232
to
fab2f7b
Compare
genevieve
commented
Oct 29, 2021
genevieve
commented
Oct 29, 2021
genevieve
commented
Oct 29, 2021
genevieve
commented
Oct 29, 2021
genevieve
commented
Oct 29, 2021
genevieve
changed the title
Add intl support with test
Add intl support with test + remove windows build
Nov 3, 2021
dylanahsmith
reviewed
Nov 3, 2021
dylanahsmith
approved these changes
Nov 3, 2021
Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want internationalization support provided by V8 by default.
Changes
Old Windows Notes
__init__.py
files in all directories of the path forv8.build.util.lastchange
to be imported into our build script.If we do not want to embed ICU data into the v8 binary, we can revert the windows python2 stuff but we then need to figure out how to get the path to the v8 executable from
v8go.cc
so we can run the v8 functionInitializeICUDefaultLocation(v8-exec-path)
which will initialize icu and find the icu data file next to wherever the executable is located.