Support for go mod vendor #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmc
approved these changes
Dec 23, 2020
genevieve
pushed a commit
to Shopify/v8go
that referenced
this pull request
Oct 28, 2021
genevieve
pushed a commit
to Shopify/v8go
that referenced
this pull request
Oct 28, 2021
genevieve
pushed a commit
to Shopify/v8go
that referenced
this pull request
Nov 16, 2021
* Add intl support with test * Update V8 static library for macos-latest * Update V8 static library for ubuntu-18.04 * Temporarily disable build for mac/ubuntu, try windows with python2 * Change import statement for python2 * Force __init__.py to be created for python2 * Try rogchap#60 * Create __init__.py all the way down * Update intl_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
go mod vendor, the command only copies folders that contain imported Go packages.By adding a Go packages to all the folders that contain V8 libs and header files will insure all these files are copied
to the vendor directory when running
go mod vendor.Fixes #34
Ref #53