Slate featured collection + collection list sections #30
Conversation
cshold
force-pushed
the
slate-sections
branch
from
f3f1be3 to
ebfdb60
Compare
|
|
||
| {%- assign collection = collections[section.settings.collection] -%} | ||
|
|
||
| {% for product in collection.products limit: 6 %} |
There was a problem hiding this comment.
Do we want to add the limit as a setting?
There was a problem hiding this comment.
Thought about it, but no. Not every theme will want it as a setting so shouldn't be included in Slate
|
Small comment (curiosity), everything else looks spot on 👍 |
| {% include 'no-blocks' %} | ||
| {% endif %} | ||
|
|
||
| {% schema %} |
There was a problem hiding this comment.
let's go with the folder approach and move these into their own .json files so we get all our fancy linting and tooling benefits
There was a problem hiding this comment.
Sounds like we're going to scrap that approach as per https://docs.google.com/document/d/1Gy8bXWp4onjgMid8zLLrD3CfX-FiVET1Qt6gYSbuvUo/edit#heading=h.s1t8zejuri1s
There was a problem hiding this comment.
I assumed that was scrapping the generator, not the approach. I feel like our default theme should leverage our json linters to save devs banging their heads agains json errors in their section files.
There was a problem hiding this comment.
It's both:
Re: breaking up section files. Please stop doing this. We need to keep the directory structure of themes 1:1 with Shopify core, with the exception of global JS & CSS assets if we can't avoid that. Breaking up sections files is not the right solution to syntax highlighting. We need to own the liquid plugins for Atom/ST/VSC/etc. and make them highlight the section schema/js/css tags correctly (it's a solved problem already, see e.g. the HTML plugins that highlight the JS in <script>).
JSON linting is the only other thing it's useful for, but Shopify lets us know when those errors are attempted to uploaded too.
There was a problem hiding this comment.
dang :-( rip JSON linting for schema files.
|
|
||
| <a href="{{ collection.url }}" title="{{ 'collections.general.link_title' | t: title: title }}"> | ||
| {% if collection.image %} | ||
| {{ collection | img_url: '480x480' | img_tag: title }} | ||
| {% if collection.image != blank %} |
There was a problem hiding this comment.
indent and whitespace 👮
There was a problem hiding this comment.
Not sure I follow, indentation and whitespace looks right to me
cshold
force-pushed
the
slate-sections
branch
from
ebfdb60 to
508234d
Compare
cshold
force-pushed
the
slate-sections
branch
from
3eed036 to
4a15203
Compare
* remove inline comments to fix babel compiling errors * fixes errors on node v4.x * got rid of linting error * updates for clarity
* remove inline comments to fix babel compiling errors * fixes errors on node v4.x * got rid of linting error * updates for clarity
* remove inline comments to fix babel compiling errors * fixes errors on node v4.x * got rid of linting error * updates for clarity
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Editor demo - https://carson-blocks.myshopify.com/admin/themes/132751811/editor
Blank states
/collections/all
Home page
@Shopify/themes-fed