Update eslint comments (#30)

* remove inline comments to fix babel compiling errors * fixes errors on node v4.x * got rid of linting error * updates for clarity
Shopify · Jul 28, 2017 · 9ad368f · 9ad368f
1 parent 30752d4
commit 9ad368f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/packages/slate-tools/.babelrc b/packages/slate-tools/.babelrc
@@ -1,6 +1,6 @@
 {
   "presets": [
-    "shopify/node"
+    "shopify"
   ],
   "plugins": [
     ["add-shopify-header", {

diff --git a/packages/slate-tools/.eslintrc.json b/packages/slate-tools/.eslintrc.json
@@ -1,8 +1,7 @@
 {
   "extends": [
     "plugin:shopify/esnext",
-    "plugin:shopify/node",
-    "plugin:shopify/mocha"
+    "plugin:shopify/node"
   ],
   "rules": {
     "no-console": 0,

diff --git a/packages/slate-tools/package.json b/packages/slate-tools/package.json
@@ -40,6 +40,7 @@
     "babel-preset-shopify": "15.0.1",
     "babel-register": "6.18.0",
     "eslint": "3.10.2",
+    "eslint-plugin-node": "3.0.4",
     "eslint-plugin-shopify": "15.1.0"
   },
   "scripts": {

diff --git a/packages/slate-tools/src/config.js b/packages/slate-tools/src/config.js
@@ -1,14 +1,18 @@
 import {join, normalize} from 'path';
+import {existsSync} from 'fs';
 import findRoot from 'find-root';
 
 const workingDirectory = process.cwd();
 const currentDirectory = __dirname;
 
 const themeRoot = findRoot(workingDirectory);
+const defaultGulpPath = join(themeRoot, normalize('node_modules/.bin/gulp'));
+// Legacy path for older versions of Node.
+const legacyGulpPath = join(themeRoot, normalize('node_modules/@shopify/slate-tools/node_modules/.bin/gulp'));
 
 const config = {
   gulpFile: join(currentDirectory, 'gulpfile.js'),
-  gulp: join(themeRoot, normalize('node_modules/.bin/gulp')),
+  gulp: existsSync(defaultGulpPath) ? defaultGulpPath : legacyGulpPath,
   themeRoot,
 };