Bump @shopify/app-bridge-react from 3.7.10 to 4.1.3 #255
Conversation
dependabot
bot
added
the
dependencies
Bumps [@shopify/app-bridge-react](https://github.com/Shopify/shopify-app-bridge) from 3.7.10 to 4.1.3. - [Release notes](https://github.com/Shopify/shopify-app-bridge/releases) - [Commits](https://github.com/Shopify/shopify-app-bridge/commits) --- updated-dependencies: - dependency-name: "@shopify/app-bridge-react" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
paulomarg
force-pushed
the
dependabot/npm_and_yarn/shopify/app-bridge-react-4.1.3
branch
from
94b7f4e to
980f2e0
Compare
|
Since there are quite a few breaking changes, I made a few updates to this PR. |
| </AppBridgeProvider> | ||
| <QueryProvider> | ||
| <NavMenu> | ||
| <a href="/pagename">{t("NavigationMenu.pageName")}</a> |
There was a problem hiding this comment.
Please also add home page if the app root is not / <a href="/app" rel="home">Home</a>
| const handleClick = useCallback(() => { | ||
| navigate(url); | ||
| }, [url]); | ||
| const handleClick = useCallback(() => window.open(url), [url]); |
There was a problem hiding this comment.
Considering we are fixing the template in this PR, can we wait til the back stack fix is out. I would like to bring shopify.navigation.onNavigate to the template to fix back stack as a green path. https://github.com/Shopify/app-bridge-next/pull/345/files#diff-930d0931e69b8c66af5536e0b6fa87053b0e051c7ab29c6cee9abe1f37fb5aa8R25
=> The back stack PRs should be merged this week.
There was a problem hiding this comment.
We can wait. Will we need to change anything here though?
There was a problem hiding this comment.
Yes, we do. There are two options. I think option 1 is the best for most cases.
- Option 1: still call
navigate(url);like before but need to call extra method like so
const handleClick = useCallback(async () => {
await shopify.saveBar.leaveConfirmation();
navigate(url);
}, [url]);- Option 2: subscribe to
shopify.navigation.onNavigatelike so
shopify.navigate.onNavigate(() => {
const {url, intercept} = event;
// call intercept if the url is a SPA
intercept({
async handler() {
navigate(url);
},
});
});
...
const handleClick = useCallback(() => window.open(url), [url]);
980f2e0 to
9bec4a8
Compare
paulomarg
force-pushed
the
dependabot/npm_and_yarn/shopify/app-bridge-react-4.1.3
branch
from
9bec4a8 to
37ce380
Compare
henrytao-me
left a comment
henrytao-me
left a comment
There was a problem hiding this comment.
There is no longer a blocker from ABN. Just ship this PR when it's ready.
paulomarg
deleted the
dependabot/npm_and_yarn/shopify/app-bridge-react-4.1.3
branch
2 participants
Bumps @shopify/app-bridge-react from 3.7.10 to 4.1.3.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)