Skip to content

Conversation

@douglasmiller
Copy link
Contributor

WHY are these changes introduced?

Fixes an issue introduced in #255 where non-external links open in a new window.

WHAT is this pull request doing?

This fix updates the window.open call to include a target of _self.

@douglasmiller
Copy link
Contributor Author

I have signed the CLA!

Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@matteodepalo matteodepalo merged commit 69a1b7c into Shopify:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants