Do not print type parameters as TYPE_ when translating to RBS
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
approved these changes
Jan 15, 2025
vinistock
approved these changes
Jan 15, 2025
vinistock
reviewed
Jan 15, 2025
| @@ -385,7 +385,7 @@ def foo(a); end | |||
|
|
|||
| # To avoid conflict with existing constants, we prefix type parameters with `TYPE_` | |||
| assert_equal(<<~RBI, rbi.rbs_string) | |||
| def foo: [TYPE_U, TYPE_V] (TYPE_U a) -> TYPE_V | |||
| def foo: [U, V] (U a) -> V | |||
There was a problem hiding this comment.
We need to remove the comment above this assertion
There was a problem hiding this comment.
Good catch, fixed 👍
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-rbs-method-type-params
branch
from
c239e18 to
9216a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually don't need to translate these types with the
TYPE_prefix to differentiate from actual types.Since all type parameters need to be declared in the signature preamble, we can easily figure which types are parameters and which ones are actual types.