Do not print type parameters as TYPE_ when translating to RBS

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Shopify · Jan 14, 2025 · c239e18 · c239e18
1 parent e9c6406
commit c239e18
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/rbi/rbs_printer.rb b/lib/rbi/rbs_printer.rb
@@ -349,7 +349,7 @@ def visit_method(node)
     sig { params(node: RBI::Method, sig: Sig).void }
     def print_method_sig(node, sig)
       unless sig.type_params.empty?
-        print("[#{sig.type_params.map { |t| "TYPE_#{t}" }.join(", ")}] ")
+        print("[#{sig.type_params.join(", ")}] ")
       end
 
       block_param = node.params.find { |param| param.is_a?(BlockParam) }
@@ -955,7 +955,7 @@ def visit_proc(type)
 
     sig { params(type: Type::TypeParameter).void }
     def visit_type_parameter(type)
-      @string << "TYPE_#{type.name}"
+      @string << type.name.to_s
     end
 
     sig { params(type: Type::Class).void }

diff --git a/test/rbi/rbs_printer_test.rb b/test/rbi/rbs_printer_test.rb
@@ -385,7 +385,7 @@ def foo(a); end
 
       # To avoid conflict with existing constants, we prefix type parameters with `TYPE_`
       assert_equal(<<~RBI, rbi.rbs_string)
-        def foo: [TYPE_U, TYPE_V] (TYPE_U a) -> TYPE_V
+        def foo: [U, V] (U a) -> V
       RBI
     end