Tag updates #9324
Merged
Tag updates #9324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Yuraima Estevez <4642404+yurm04@users.noreply.github.com>
sarahill
requested changes
May 30, 2023
There was a problem hiding this comment.
Overall looks good. Just noticed a couple things.
Removable tags:
xicon should useicon-subduedfor default state andicon-primaryfor hover, active, and focus
Removable and clickable tags:
- The background color of the tags for the pressed state should use
bg-strong-hover+bg-strong-active
sophschneider
pushed a commit
that referenced
this pull request
Jun 1, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Replaces #9256 Fixes Shopify/archive-polaris-backlog-2024#24 --------- Co-authored-by: Yuraima Estevez <4642404+yurm04@users.noreply.github.com>
sophschneider
pushed a commit
that referenced
this pull request
Jun 1, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Replaces #9256 Fixes Shopify/archive-polaris-backlog-2024#24 --------- Co-authored-by: Yuraima Estevez <4642404+yurm04@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Replaces #9256
Fixes https://github.com/Shopify/polaris-summer-editions/issues/24