Skip to content

v11.x.x Updates to Tag #9256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

v11.x.x Updates to Tag #9256

wants to merge 4 commits into from

Conversation

@yurm04
Copy link
Contributor

@yurm04 yurm04 commented May 23, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-summer-editions/issues/24

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023 •
edited
Loading

size-limit report 📦

Path Size
polaris-react-cjs 243.08 KB (0%)
polaris-react-esm 157.34 KB (0%)
polaris-react-esnext 220.28 KB (+0.11% 🔺)
polaris-react-css 47.93 KB (+0.44% 🔺)

@yurm04 yurm04 force-pushed the ye/v11.x.x-tags branch from f4efe92 to 9395d66 Compare May 25, 2023 19:59
@yurm04 yurm04 requested a review from sarahill May 26, 2023 18:33
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label May 26, 2023
@github-actions github-actions bot removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label May 26, 2023
@yurm04 yurm04 marked this pull request as ready for review May 26, 2023 21:02
@yurm04
Copy link
Contributor Author

yurm04 commented May 26, 2023

@kyledurand caught up with @sarahill and confirmed that the tokens used in the new Tag will have updated values. The styling should all be correct once those changes go through but please double check before merging

@yurm04 yurm04 assigned kyledurand and unassigned kyledurand May 26, 2023
@yurm04 yurm04 requested a review from kyledurand May 26, 2023 21:08
kyledurand
kyledurand reviewed May 29, 2023
View reviewed changes
@kyledurand kyledurand self-assigned this May 30, 2023
kyledurand and others added 3 commits May 30, 2023 14:23
@kyledurand @laurkim
Add global class and scss helper (#9238)
35f7a8b 
Help with toggling between current and se23

Toggles a class on the document root that we can hook into via a handy
sass var:

```scss
  #{$se23} & {
    --pc-button-color: var(--p-text);
  }
```

---------

Co-authored-by: Lo Kim <lo.kim@shopify.com>
@kyledurand
started updating styling
6114e2f
@kyledurand
comments
172f1d5
@sarahill
Copy link
Contributor

sarahill commented May 30, 2023 •
edited
Loading

Noticed some jumpiness on the clickable tag hover state
tag-hover-jump

@kyledurand kyledurand mentioned this pull request May 30, 2023
Merged
@kyledurand
Copy link
Member

Closing for #9324

@kyledurand kyledurand closed this May 31, 2023
@kyledurand kyledurand deleted the ye/v11.x.x-tags branch May 31, 2023 19:15
kyledurand added a commit that referenced this pull request May 31, 2023
@kyledurand @yurm04
Tag updates (#9324)
27e3930 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Replaces #9256

Fixes Shopify/archive-polaris-backlog-2024#24

---------

Co-authored-by: Yuraima Estevez <4642404+yurm04@users.noreply.github.com>
sophschneider pushed a commit that referenced this pull request Jun 1, 2023
@kyledurand @yurm04 @sophschneider
Tag updates (#9324)
bb84dab 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Replaces #9256

Fixes Shopify/archive-polaris-backlog-2024#24

---------

Co-authored-by: Yuraima Estevez <4642404+yurm04@users.noreply.github.com>
sophschneider pushed a commit that referenced this pull request Jun 1, 2023
@kyledurand @yurm04 @sophschneider
Tag updates (#9324)
14ecb57 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Replaces #9256

Fixes Shopify/archive-polaris-backlog-2024#24

---------

Co-authored-by: Yuraima Estevez <4642404+yurm04@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand left review comments

@sarahill sarahill Awaiting requested review from sarahill

Assignees

@kyledurand kyledurand

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yurm04 @sarahill @kyledurand