Skip to content

Add deprecated v10 custom properties to stylelint-polaris #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 13, 2023
Merged

Add deprecated v10 custom properties to stylelint-polaris #8549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80ec117
Add changeset
lgriffee Mar 3, 2023
e894a53
Add deprecated border tokens
lgriffee Mar 3, 2023
4ccc5bb
Add deprecated color tokens
lgriffee Mar 3, 2023
35caa37
Add deprecated depth tokens
lgriffee Mar 6, 2023
c86a866
Add deprecated legacy tokens
lgriffee Mar 6, 2023
39c5012
Add deprecated z-index tokens
lgriffee Mar 6, 2023
28ef480
Move legacy tokens into appropriate categories
lgriffee Mar 6, 2023
cfa4703
Merge branch 'main' of https://github.com/Shopify/polaris into stylel…
lgriffee Mar 13, 2023
9ac30a1
Add deprecated depth tokens
lgriffee Mar 13, 2023
2444635
Update .changeset/grumpy-cars-hide.md
lgriffee Apr 12, 2023
0b55359
Merge branch 'main' into stylelint-add-v11-legacy
lgriffee Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/grumpy-cars-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/stylelint-polaris': major
---

Add deprecated v10 custom properties to stylelint-polaris global-disallowed-list
190 changes: 188 additions & 2 deletions stylelint-polaris/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,151 @@ const stylelintPolarisCoverageOptions = {
/\$polaris-colors/,
/\$color-filter-palette-data/,
/\$color-palette-data/,
// Legacy custom properties
/--p-override-transparent/,
/--p-badge-mix-blend-mode/,
/--p-text-warning/,
/--p-text-success/,
/--p-text-subdued-on-dark/,
/--p-text-subdued/,
/--p-text-primary-pressed/,
/--p-text-primary-hovered/,
/--p-text-primary/,
/--p-text-on-primary/,
/--p-text-on-interactive/,
/--p-text-on-dark/,
/--p-text-on-critical/,
/--p-text-highlight/,
/--p-text-disabled/,
/--p-text-critical/,
/--p-text/,
/--p-surface-warning-subdued-pressed/,
/--p-surface-warning-subdued-hovered/,
/--p-surface-warning-subdued/,
/--p-surface-warning/,
/--p-surface-success-subdued-pressed/,
/--p-surface-success-subdued-hovered/,
/--p-surface-success-subdued /,
/--p-surface-success/,
/--p-surface-subdued/,
/--p-surface-selected-pressed/,
/--p-surface-selected-hovered/,
/--p-surface-selected/,
/--p-surface-search-field-dark/,
/--p-surface-search-field/,
/--p-surface-primary-selected-pressed/,
/--p-surface-primary-selected-hovered/,
/--p-surface-primary-selected/,
/--p-surface-pressed-dark/,
/--p-surface-pressed/,
/--p-surface-neutral-subdued-dark/,
/--p-surface-neutral-subdued/,
/--p-surface-neutral-pressed/,
/--p-surface-neutral-hovered/,
/--p-surface-neutral-disabled/,
/--p-surface-neutral/,
/--p-surface-hovered-dark/,
/--p-surface-hovered/,
/--p-surface-highlight-subdued-pressed/,
/--p-surface-highlight-subdued-hovered/,
/--p-surface-highlight-subdued/,
/--p-surface-highlight/,
/--p-surface-disabled/,
/--p-surface-depressed/,
/--p-surface-dark/,
/--p-surface-critical-subdued-pressed/,
/--p-surface-critical-subdued-hovered/,
/--p-surface-critical-subdued-depressed/,
/--p-surface-critical-subdued/,
/--p-surface-critical/,
/--p-surface-attention/,
/--p-surface/,
/--p-shadow-color-picker-dragger/,
/--p-shadow-color-picker/,
/--p-overlay/,
/--p-interactive-pressed-on-dark/,
/--p-interactive-pressed/,
/--p-interactive-on-dark/,
/--p-interactive-hovered/,
/--p-interactive-disabled/,
/--p-interactive-critical-pressed/,
/--p-interactive-critical-hovered/,
/--p-interactive-critical-disabled/,
/--p-interactive-critical/,
/--p-interactive/,
/--p-icon-warning/,
/--p-icon-success/,
/--p-icon-subdued/,
/--p-icon-pressed/,
/--p-icon-on-primary/,
/--p-icon-on-interactive/,
/--p-icon-on-dark/,
/--p-icon-on-critical/,
/--p-icon-hovered/,
/--p-icon-highlight/,
/--p-icon-disabled/,
/--p-icon-critical/,
/--p-icon-attention/,
/--p-icon/,
/--p-hint-from-direct-light/,
/--p-focused/,
/--p-divider-dark/,
/--p-divider/,
/--p-decorative-two-text/,
/--p-decorative-two-surface/,
/--p-decorative-two-icon/,
/--p-decorative-three-text/,
/--p-decorative-three-surface/,
/--p-decorative-three-icon/,
/--p-decorative-one-text/,
/--p-decorative-one-surface/,
/--p-decorative-one-icon/,
/--p-decorative-four-text/,
/--p-decorative-four-surface/,
/--p-decorative-four-icon/,
/--p-decorative-five-text/,
/--p-decorative-five-surface/,
/--p-decorative-five-icon/,
/--p-border-warning-subdued/,
/--p-border-warning/,
/--p-border-success-subdued/,
/--p-border-success/,
/--p-border-subdued/,
/--p-border-shadow-subdued/,
/--p-border-shadow/,
/--p-border-on-dark/,
/--p-border-neutral-subdued/,
/--p-border-hovered/,
/--p-border-highlight-subdued/,
/--p-border-highlight/,
/--p-border-disabled/,
/--p-border-depressed/,
/--p-border-critical-subdued/,
/--p-border-critical-disabled/,
/--p-border-critical/,
/--p-border/,
/--p-background-selected/,
/--p-background-pressed/,
/--p-background-hovered/,
/--p-background/,
/--p-backdrop/,
/--p-action-secondary-pressed-dark/,
/--p-action-secondary-pressed/,
/--p-action-secondary-hovered-dark/,
/--p-action-secondary-hovered/,
/--p-action-secondary-disabled/,
/--p-action-secondary-depressed/,
/--p-action-secondary/,
/--p-action-primary-pressed/,
/--p-action-primary-hovered/,
/--p-action-primary-disabled/,
/--p-action-primary-depressed/,
/--p-action-primary/,
/--p-action-critical-pressed/,
/--p-action-critical-hovered/,
/--p-action-critical-disabled/,
/--p-action-critical-depressed/,
/--p-action-critical/,
],
},
{
Expand Down Expand Up @@ -211,6 +356,8 @@ const stylelintPolarisCoverageOptions = {
/--p-range-slider-thumb-size-base/,
/--p-range-slider-thumb-size-active/,
/--p-choice-size/,
/--p-icon-size-small/,
/--p-icon-size-medium/,
],
},
{
Expand All @@ -236,6 +383,7 @@ const stylelintPolarisCoverageOptions = {
/--p-button-group-item-spacing/,
/--p-choice-margin/,
/--p-text-field-spinner-offset/,
/--p-frame-offset/,
],
},
{
Expand Down Expand Up @@ -264,9 +412,10 @@ const stylelintPolarisCoverageOptions = {
},
'polaris/global-disallowed-list': [
// Legacy custom properties
// /--p-border-radius-base/,
/--p-border-radius-base/,
/--p-border-radius-large/,
/--p-border-radius-wide/,
// /--p-border-radius-full/,
/--p-border-radius-half/,
/--p-control-border-width/,
/--p-thin-border-subdued/,
/--p-banner-border-default/,
Expand All @@ -275,6 +424,11 @@ const stylelintPolarisCoverageOptions = {
/--p-banner-border-warning/,
/--p-banner-border-critical/,
/--p-text-field-focus-ring-offset/,
/--p-border-base/,
/--p-border-dark/,
/--p-border-transparent/,
/--p-border-divider/,
/--p-border-divider-on-dark/,
],
},
{
Expand All @@ -293,6 +447,26 @@ const stylelintPolarisCoverageOptions = {
'polaris/global-disallowed-list': [
// Legacy mixin map-get data
/\$shadows-data/,
// Legacy custom properties
/--p-button-drop-shadow/,
/--p-button-inner-shadow/,
/--p-button-pressed-inner-shadow/,
/--p-card-shadow/,
/--p-popover-shadow/,
/--p-modal-shadow/,
/--p-top-bar-shadow/,
/--p-shadow-transparent/,
/--p-shadow-faint/,
/--p-shadow-base/,
/--p-shadow-deep/,
/--p-shadow-button/,
/--p-shadow-top-bar/,
/--p-shadow-card/,
/--p-shadow-popover/,
/--p-shadow-layer/,
/--p-shadow-modal/,
/--p-shadows-inset-button/,
/--p-shadows-inset-button-pressed/,
],
},
{
Expand All @@ -315,6 +489,18 @@ const stylelintPolarisCoverageOptions = {
/\$global-elements/,
// Legacy custom properties
/--p-override-loading-z-index/,
/--p-z-1/,
/--p-z-2/,
/--p-z-3/,
/--p-z-4/,
/--p-z-5/,
/--p-z-6/,
/--p-z-7/,
/--p-z-8/,
/--p-z-9/,
/--p-z-10/,
/--p-z-11/,
/--p-z-12/,
],
},
{
Expand Down