Skip to content

Add deprecated v10 custom properties to stylelint-polaris #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 13, 2023
Merged

Add deprecated v10 custom properties to stylelint-polaris #8549

merged 11 commits into from
Apr 13, 2023

Conversation

@lgriffee
Copy link
Contributor

@lgriffee lgriffee commented Mar 3, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes #8419

We want to ship this as a breaking change for stylelint-polaris prior to the v11 release to ease our major version upgrade of Polaris v11 in web.

WHAT is this pull request doing?

Adds these deprecated v10 custom properties to stylelint-polaris.

@lgriffee lgriffee self-assigned this Mar 3, 2023
@lgriffee lgriffee marked this pull request as ready for review April 12, 2023 15:50
@lgriffee lgriffee changed the title Add deprecated v11 custom properties to stylelint-polaris Add deprecated v10 custom properties to stylelint-polaris Apr 12, 2023
lgriffee
lgriffee commented Apr 12, 2023
View reviewed changes
alex-page
alex-page approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. At some point in time... probably when v11 ships we should come back and clean this up.

@lgriffee
Copy link
Contributor Author

lgriffee commented Apr 13, 2023 •
edited
Loading

This is great. At some point in time... probably when v11 ships we should come back and clean this up.

Yes, @alex-page 100%! When we created #8419 we also created #8420 which we plan to tackle after the v11 release!

@aaronccasanova aaronccasanova merged commit e0ff210 into main Apr 13, 2023
@aaronccasanova aaronccasanova deleted the stylelint-add-v11-legacy branch April 13, 2023 19:48
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Apr 13, 2023
Merged
alex-page added a commit that referenced this pull request Apr 17, 2023
@alex-page
Revert "Add deprecated v10 custom properties to stylelint-polaris (#…
85027c6 
…8549)"

This reverts commit e0ff210.
@alex-page alex-page restored the stylelint-add-v11-legacy branch April 17, 2023 01:28
alex-page added a commit that referenced this pull request Apr 17, 2023
@alex-page
Revert "Add deprecated v10 custom properties to stylelint-polaris (#…
4ae3f34 
…8549)"

This reverts commit e0ff210.
lgriffee added a commit that referenced this pull request Apr 17, 2023
@lgriffee
Add deprecated v10 custom properties to stylelint-polaris (#8549)
24712c8
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@lgriffee @juzser
Add deprecated v10 custom properties to stylelint-polaris (Shopify#…
6686faa 
…8549)
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@alex-page @juzser
Revert "Add deprecated v10 custom properties to stylelint-polaris (S…
6f1bca9 
…hopify#8549)"

This reverts commit e0ff210.
@lgriffee lgriffee mentioned this pull request Aug 3, 2023
Merged
lgriffee added a commit that referenced this pull request Aug 15, 2023
@lgriffee
Remove deprecated v10 custom properties from stylelint-polaris (#9887)
a3da87e 
### WHY are these changes introduced?

Fixes #8420

### WHAT is this pull request doing?

Removes [these deprecated v10 custom
properties](#8405) from
`stylelint-polaris` which were added in
#8549 and
#9074.
@alex-page alex-page deleted the stylelint-add-v11-legacy branch November 27, 2023 03:21
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@lgriffee
Add deprecated v10 custom properties to stylelint-polaris (Shopify#…
082138a 
…8549)
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@alex-page
Revert "Add deprecated v10 custom properties to stylelint-polaris (S…
2bc0cd7 
…hopify#8549)"

This reverts commit 082138a.
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@lgriffee
Remove deprecated v10 custom properties from stylelint-polaris (Sho…
eb73c2f 
…pify#9887)

### WHY are these changes introduced?

Fixes Shopify#8420

### WHAT is this pull request doing?

Removes [these deprecated v10 custom
properties](Shopify#8405) from
`stylelint-polaris` which were added in
Shopify#8549 and
Shopify#9074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-page alex-page alex-page approved these changes

@aaronccasanova aaronccasanova aaronccasanova approved these changes

Assignees

@lgriffee lgriffee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add deprecated v10 custom properties to stylelint-polaris

3 participants

@lgriffee @alex-page @aaronccasanova