Update `AlphaStack` #7429

aveline · 2022-10-17T22:03:21Z

WHY are these changes introduced?

Through the rebuilding of ChoiceList (#7354) I have found there are a few updates that would make AlphaStack more flexible.

WHAT is this pull request doing?

Make AlphaStack polymorphic and allow it to be a ul or a fieldset in addition to a div. Both those elements are used to contain a list or group of elements that may require equal spacing. This allows AlphaStack to be used in those instances while still providing semantic markup.
Include some reset styles for when the ul element is set on AlphaStack to override default browser styling for ul. This removes margin and padding which makes sense since spacing should be handled by layout components. It also removes the default ul bullet. Is this too opinionated? Are there use cases where AlphaStack would be used for spacing items in a list with the default browser bullet?


Default `ul` styles	Reset `ul` styles

Update AlphaStack to allow responsive spacing. The spacing prop can now accept an object with a breakpoint and the spacing value.

github-actions · 2022-10-17T22:06:55Z

size-limit report 📦

Path	Size
polaris-react-cjs	209.36 KB (+0.07% 🔺)
polaris-react-esm	135.78 KB (+0.08% 🔺)
polaris-react-esnext	191.34 KB (+0.13% 🔺)
polaris-react-css	41.69 KB (+0.27% 🔺)

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

polaris-react/src/components/AlphaStack/AlphaStack.scss

alex-page · 2022-10-19T19:53:42Z

polaris-react/src/components/AlphaStack/AlphaStack.tsx


 type Align = 'start' | 'end' | 'center';

+type Element = 'div' | 'ul' | 'fieldset';


This makes sense to me. I expect this to grow organically.

Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com>

kyledurand

Looks good! Just one comment around where that type should live. Not a blocker

kyledurand · 2022-10-24T19:53:28Z

polaris-react/src/utilities/css.ts

+export type ResponsiveProp<T> =
+  | T
+  | {
+      [Breakpoint in BreakpointsAlias]?: T;
+    };


Wondering if this should be exported from tokens instead of this css utils file? Thoughts on moving it?

@aaronccasanova would be great to get your thoughts on this

@lgriffee

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.6.0 ### Minor Changes - [#7342](#7342) [`dc2990acf`](dc2990a) Thanks [@lgriffee](https://github.com/lgriffee)! - Rename `replace-sass-length` migration to `replace-spacing-lengths` Add `gap` properties to `replace-sass-space` migration - [#7310](#7310) [`8fb215836`](8fb2158) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Add sass z-index migration - [#7335](#7335) [`699b70713`](699b707) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add migration to `replace-typography-declarations` - [#7375](#7375) [`8194e174a`](8194e17) Thanks [@samrose3](https://github.com/samrose3)! - Add Sass color function migration - [#7387](#7387) [`a0fa96ed4`](a0fa96e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added `replace-border-declarations` migration ### Patch Changes - [#7487](#7487) [`60191f353`](60191f3) Thanks [@lgriffee](https://github.com/lgriffee)! - Update numeric operator detection to check all node types - [#7412](#7412) [`6d82e8965`](6d82e89) Thanks [@samrose3](https://github.com/samrose3)! - Enhance Sass spacing migration to catch Sass interpolations - [#7423](#7423) [`0591db26a`](0591db2) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Update `replace-typography-declarations` comment strategy - [#7459](#7459) [`933a9d71b`](933a9d7) Thanks [@lgriffee](https://github.com/lgriffee)! - Add missing values to borderRadius length map ## @shopify/polaris@10.9.0 ### Minor Changes - [#7429](#7429) [`e87330f5b`](e87330f) Thanks [@aveline](https://github.com/aveline)! - Update `AlphaStack` to be polymorphic, add list reset styles and allow spacing to change based on breakpoint - [#7450](#7450) [`74237ebc5`](74237eb) Thanks [@laurkim](https://github.com/laurkim)! - Added support for `minHeight` and `minWidth` on `Box` - [#7432](#7432) [`85c022033`](85c0220) Thanks [@laurkim](https://github.com/laurkim)! - Added support for `overflowX`, `overflowY`, and `width` props to `Box` - [#7491](#7491) [`a9eff60e1`](a9eff60) Thanks [@laurkim](https://github.com/laurkim)! - Added support for `section` element types to `Box` - [#7389](#7389) [`4f184c658`](4f184c6) Thanks [@aveline](https://github.com/aveline)! - Added `breakWord` prop to `Text` - [#7430](#7430) [`87981ac01`](87981ac) Thanks [@aveline](https://github.com/aveline)! - Added `legend` as supported element for `Text` component - [#7438](#7438) [`4b4411930`](4b44119) Thanks [@aveline](https://github.com/aveline)! - Simplify `AlphaCard` by removing `hasBorderRadius` prop and `shadow` prop ### Patch Changes - [#7405](#7405) [`ea2615881`](ea26158) Thanks [@laurkim](https://github.com/laurkim)! - Fixed how optional `id` prop rendered in `Text` - [#7434](#7434) [`62288755a`](6228875) Thanks [@laurkim](https://github.com/laurkim)! - Fixed reference to `width` custom property in `Box` - [#7396](#7396) [`3be27bae8`](3be27ba) Thanks [@laurkim](https://github.com/laurkim)! - Updated alias and scale types in `Box` with type tests to check they exist in our token groups. Updated `get-props` script to parse utility types with unions. - [#7435](#7435) [`4097d539b`](4097d53) Thanks [@kyledurand](https://github.com/kyledurand)! - Cleaned up styles on Box - [#7410](#7410) [`13546e344`](13546e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Apply default value to Columns - [#7483](#7483) [`7a78e07bf`](7a78e07) Thanks [@laurkim](https://github.com/laurkim)! - Fixed missing `children` prop in `Columns` prop type - [#7492](#7492) [`612e02786`](612e027) Thanks [@henryyi](https://github.com/henryyi)! - Only apply scroll-lock with scrollbar when body is scrollable - [#7481](#7481) [`4f5f6cf50`](4f5f6cf) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed horizontal scroll bug in Scrollable - [#7471](#7471) [`2f16b2310`](2f16b23) Thanks [@kyledurand](https://github.com/kyledurand)! - Added viewport addon to storybook and matched values to our breakpoints - [#7433](#7433) [`90487fd70`](90487fd) Thanks [@kellymiller-shop](https://github.com/kellymiller-shop)! - fixed heading offset on IndexTable - [#7453](#7453) [`3191d13c0`](3191d13) Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Fixed IndexTable not rendering bulk actions on resize - [#7395](#7395) [`89fea23f7`](89fea23) Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Fixed scrolling performance for IndexTable on safari - [#7442](#7442) [`77057d5b6`](77057d5) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix SkeletonPage actions layout ## @shopify/plugin-polaris@0.0.12 ### Patch Changes - Updated dependencies \[[`dc2990acf`](dc2990a), [`8fb215836`](8fb2158), [`60191f353`](60191f3), [`6d82e8965`](6d82e89), [`0591db26a`](0591db2), [`699b70713`](699b707), [`8194e174a`](8194e17), [`933a9d71b`](933a9d7), [`a0fa96ed4`](a0fa96e)]: - @shopify/polaris-migrator@0.6.0 ## polaris.shopify.com@0.23.0 ### Minor Changes - [#7396](#7396) [`3be27bae8`](3be27ba) Thanks [@laurkim](https://github.com/laurkim)! - Updated alias and scale types in `Box` with type tests to check they exist in our token groups. Updated `get-props` script to parse utility types with unions. - [#7393](#7393) [`cd4577a3f`](cd4577a) Thanks [@martenbjork](https://github.com/martenbjork)! - Update markdown file structure to not require folders for each markdown page. Now you can simply create a markdown.md file and it will be rendered as a page. - [#7418](#7418) [`c5cfe9026`](c5cfe90) Thanks [@kyledurand](https://github.com/kyledurand)! - Support beta status components - [#7449](#7449) [`31437dfb2`](31437df) Thanks [@jjgali](https://github.com/jjgali)! - Removed duplicate image on error messages page. - [#7491](#7491) [`a9eff60e1`](a9eff60) Thanks [@laurkim](https://github.com/laurkim)! - Added support for `section` element types to `Box` - [#7441](#7441) [`0d446cb46`](0d446cb) Thanks [@jjgali](https://github.com/jjgali)! - Remove section on compositions vs patterns. - [#7420](#7420) [`d462e2e5d`](d462e2e) Thanks [@jjgali](https://github.com/jjgali)! - Clarify rules for formatting dates and times. ### Patch Changes - [#7398](#7398) [`c21ea83d4`](c21ea83) Thanks [@tracytees](https://github.com/tracytees)! - - Updated the "Getting started" and "Polaris 101" pages - Removed /design, /develop, /shared-resources, /patterns-components-and-tokens - [#7426](#7426) [`442d51ddf`](442d51d) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Fix nav bug - [#7452](#7452) [`8a05e840f`](8a05e84) Thanks [@gui-santos](https://github.com/gui-santos)! - fix visual bug in token page's navigation where text was breaking into two lines - [#7469](#7469) [`a8d80cfd5`](a8d80cf) Thanks [@chazdean](https://github.com/chazdean)! - Updated `AlphaStack` component docs - [#7483](#7483) [`7a78e07bf`](7a78e07) Thanks [@laurkim](https://github.com/laurkim)! - Fixed missing `children` prop in `Columns` prop type - [#7436](#7436) [`95a8ac0d2`](95a8ac0) Thanks [@laurkim](https://github.com/laurkim)! - Fix references to `Box` margin props in alpha layout examples - [#7444](#7444) [`e0d6b00ba`](e0d6b00) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix tile image and increase example widths on alpha components - [#7427](#7427) [`25e70a8d9`](25e70a8) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Declare sandbox nav in a more idiomatic fashion - [#7482](#7482) [`0ec6961aa`](0ec6961) Thanks [@alex-page](https://github.com/alex-page)! - Bump GitHub action versions and add p-map for gen-og-images CI failure - Updated dependencies \[[`ea2615881`](ea26158), [`62288755a`](6228875), [`3be27bae8`](3be27ba), [`4097d539b`](4097d53), [`e87330f5b`](e87330f), [`74237ebc5`](74237eb), [`85c022033`](85c0220), [`13546e344`](13546e3), [`7a78e07bf`](7a78e07), [`a9eff60e1`](a9eff60), [`4f184c658`](4f184c6), [`612e02786`](612e027), [`4f5f6cf50`](4f5f6cf), [`87981ac01`](87981ac), [`2f16b2310`](2f16b23), [`90487fd70`](90487fd), [`3191d13c0`](3191d13), [`89fea23f7`](89fea23), [`77057d5b6`](77057d5), [`4b4411930`](4b44119)]: - @shopify/polaris@10.9.0 ## polaris-for-figma@0.0.25 ### Patch Changes - Updated dependencies \[[`ea2615881`](ea26158), [`62288755a`](6228875), [`3be27bae8`](3be27ba), [`4097d539b`](4097d53), [`e87330f5b`](e87330f), [`74237ebc5`](74237eb), [`85c022033`](85c0220), [`13546e344`](13546e3), [`7a78e07bf`](7a78e07), [`a9eff60e1`](a9eff60), [`4f184c658`](4f184c6), [`612e02786`](612e027), [`4f5f6cf50`](4f5f6cf), [`87981ac01`](87981ac), [`2f16b2310`](2f16b23), [`90487fd70`](90487fd), [`3191d13c0`](3191d13), [`89fea23f7`](89fea23), [`77057d5b6`](77057d5), [`4b4411930`](4b44119)]: - @shopify/polaris@10.9.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Update AlphaStack

51af10b

aveline requested review from chazdean, kyledurand, laurkim, nayeobkim and sarahill October 17, 2022 22:03

aveline added the #gsd:30116 label Oct 17, 2022

aveline self-assigned this Oct 18, 2022

Update AlphaStack to support responsive spacing

bee84fd

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

alex-page reviewed Oct 19, 2022

View reviewed changes

polaris-react/src/components/AlphaStack/AlphaStack.scss Show resolved Hide resolved

alex-page reviewed Oct 19, 2022

View reviewed changes

aveline and others added 7 commits October 19, 2022 14:34

Add ol as a supported element

b7d117d

changeset

aefe235

Merge branch 'main' into update-alpha-stack

4ce25f7

👕 fix linting

dd0dabe

Move getResponsiveProps to shared utils

1d22713

Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com>

Add tests

5a43545

Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com>

Update css.test.ts

ed9201b

aveline marked this pull request as ready for review October 21, 2022 19:13

aveline requested a review from aaronccasanova October 21, 2022 21:36

laurkim approved these changes Oct 24, 2022

View reviewed changes

kyledurand approved these changes Oct 24, 2022

View reviewed changes

aveline merged commit e87330f into main Oct 24, 2022

aveline deleted the update-alpha-stack branch October 24, 2022 22:01

github-actions bot mentioned this pull request Oct 24, 2022

Version Packages #7406

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `AlphaStack` #7429

Update `AlphaStack` #7429

Uh oh!

aveline commented Oct 17, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Oct 17, 2022 •

edited

Loading

Uh oh!

Uh oh!

alex-page Oct 19, 2022

Uh oh!

kyledurand left a comment

Uh oh!

kyledurand Oct 24, 2022

Uh oh!

aveline Oct 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		type Align = 'start' \| 'end' \| 'center';

		type Element = 'div' \| 'ul' \| 'fieldset';

Update AlphaStack #7429

Update AlphaStack #7429

Uh oh!

Conversation

aveline commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

Uh oh!

github-actions bot commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

alex-page Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

kyledurand left a comment

Choose a reason for hiding this comment

Uh oh!

kyledurand Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

aveline Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update `AlphaStack` #7429

Update `AlphaStack` #7429

aveline commented Oct 17, 2022 •

edited

Loading

github-actions bot commented Oct 17, 2022 •

edited

Loading