Skip to content

Commit 7a78e07

Browse files
authored
[Columns/Box] Add missing children prop back to prop type (#7483)
### WHY are these changes introduced? The `children` prop must have been accidentally deleted in a previous PR so adding it back. ### WHAT is this pull request doing? Adds `children` as optional prop to `ColumnsProps`. Also runs `get-props` script in styleguide so props are updated. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent 0ec6961 commit 7a78e07

File tree

3 files changed

+1092
-1060
lines changed

3 files changed

+1092
-1060
lines changed

.changeset/large-peas-happen.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@shopify/polaris': patch
3+
'polaris.shopify.com': patch
4+
---
5+
6+
Fixed missing `children` prop in `Columns` prop type

polaris-react/src/components/Columns/Columns.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export interface ColumnsProps extends PropsWithChildren {
2323
* @default {xs: 6, sm: 6, md: 6, lg: 6, xl: 6}
2424
*/
2525
columns?: Columns;
26+
children?: React.ReactNode;
2627
}
2728

2829
export function Columns({columns, children, spacing}: ColumnsProps) {

0 commit comments

Comments
 (0)